From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41200) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V0J2G-0001Fs-Vz for qemu-devel@nongnu.org; Fri, 19 Jul 2013 18:20:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V0J2G-000867-12 for qemu-devel@nongnu.org; Fri, 19 Jul 2013 18:20:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:7937) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V0ItP-0005bA-NB for qemu-devel@nongnu.org; Fri, 19 Jul 2013 18:11:15 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6JMBFPv006955 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 19 Jul 2013 18:11:15 -0400 Message-ID: <51E9B981.2000104@redhat.com> Date: Fri, 19 Jul 2013 16:11:13 -0600 From: Eric Blake MIME-Version: 1.0 References: <1374253411-17162-1-git-send-email-imain@redhat.com> <1374253411-17162-2-git-send-email-imain@redhat.com> <51E99656.7020209@redhat.com> <20130719214900.GE13675@gate.mains.priv> In-Reply-To: <20130719214900.GE13675@gate.mains.priv> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Sk2BhjlgbmFlifgbPIp6FLtdqSPHdScpr" Subject: Re: [Qemu-devel] [PATCH V5 1/4] Implement sync modes for drive-backup. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ian Main Cc: kwolf@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, rjones@redhat.com, stefanha@redhat.com, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Sk2BhjlgbmFlifgbPIp6FLtdqSPHdScpr Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/19/2013 03:49 PM, Ian Main wrote: >>> +++ b/qapi-schema.json >>> @@ -1807,6 +1807,10 @@ >>> # @format: #optional the format of the new destination, default is t= o >>> # probe if @mode is 'existing', else the format of the sour= ce >>> # >>> +# @sync: what parts of the disk image should be copied to the destin= ation >>> +# (all the disk, only the sectors allocated in the topmost im= age, or >>> +# only new I/O). >>> +# >>> # @mode: #optional whether and how QEMU should create a new image, d= efault is >>> # 'absolute-paths'. >>> # >> >> This hunk is still wrong. And we still haven't answered the >> meta-question on whether @format should be mandatory (which I'd rather= >> fix that first, then rebase this on top of that). >=20 > How is it wrong when it cleanly applies? You want it separated into > another patch? It cleanly applied to the wrong place (drive-mirror), no thanks to git's automatic fuzzing. It is _no longer necessary_ - DriveBackup already has this information. I want it dropped completely. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Sk2BhjlgbmFlifgbPIp6FLtdqSPHdScpr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJR6bmBAAoJEKeha0olJ0NqrWkH/R5LTfaiA4p9rXHq2ulNc13x goc0tQ95HUC+JoB8i+BR9u33K/7psxfvYwozhS749eDZE+EjmQ5dLh5YQ2amtsnz LoIhe9VMdIY8IUKCGcPoRG6Ynrr9gMAvPPfpJmdWxsT9jx4k5GGMskdTTE16HHf1 SrIiJYZA9kptBWvt204U33yuge9zbmQ1mdvvFuh3m6Gg0uYdtGdKowY1zBKNC4Dz rOK1gNGj21PNxTWngzToWyB4k9q2vLke8YQgeRR+L2Cb18n58oQjo0O6c/385wru FiPz709ApzWADc6FsSx1e85gwH+/f7kJCQzVgI07GewyEXFJrx54heohgiZlSeI= =KpGl -----END PGP SIGNATURE----- --Sk2BhjlgbmFlifgbPIp6FLtdqSPHdScpr--