From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39225)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V0Vai-0005Ve-TI
	for qemu-devel@nongnu.org; Sat, 20 Jul 2013 07:44:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V0Vah-0001Nj-EP
	for qemu-devel@nongnu.org; Sat, 20 Jul 2013 07:44:48 -0400
Received: from cantor2.suse.de ([195.135.220.15]:46960 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V0Vah-0001NW-69
	for qemu-devel@nongnu.org; Sat, 20 Jul 2013 07:44:47 -0400
Message-ID: <51EA7823.6070208@suse.de>
Date: Sat, 20 Jul 2013 13:44:35 +0200
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <cover.1373603020.git.peter.crosthwaite@xilinx.com>
	<311d6862f24292bb5099467f34eb5cbcf81fc708.1373603020.git.peter.crosthwaite@xilinx.com>
In-Reply-To: <311d6862f24292bb5099467f34eb5cbcf81fc708.1373603020.git.peter.crosthwaite@xilinx.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [RFC PATCH v1 2/3] device_tree: qemu_fdt_setprop:
 Rename val_array arg
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: peter.crosthwaite@xilinx.com
Cc: peter.maydell@linaro.org, david@gibson.dropbear.id.au, qemu-devel@nongnu.org, agraf@suse.de

Am 12.07.2013 06:29, schrieb peter.crosthwaite@xilinx.com:
> From: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
>=20
> Looking at the implementation, this doesn't really have a lot to do
> with arrays. Its just a pointer to a buffer and is passed through
> to the wrapped fn (qemu_fdt_setprop) unchanged. So rename to make it
> consistent with libfdt, which in the wrapped function just calls it
> "val".
>=20
> Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
> ---
>=20
>  device_tree.c                | 4 ++--
>  include/sysemu/device_tree.h | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Andreas F=E4rber <afaerber@suse.de>

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg