From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44289) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V0VrV-0004qA-Fr for qemu-devel@nongnu.org; Sat, 20 Jul 2013 08:02:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V0VrU-0007PY-KA for qemu-devel@nongnu.org; Sat, 20 Jul 2013 08:02:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:26646) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V0VrU-0007PR-Bo for qemu-devel@nongnu.org; Sat, 20 Jul 2013 08:02:08 -0400 Message-ID: <51EA7C3D.4040509@redhat.com> Date: Sat, 20 Jul 2013 06:02:05 -0600 From: Eric Blake MIME-Version: 1.0 References: <1374284656-12025-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1374284656-12025-5-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1374284656-12025-5-git-send-email-xiawenc@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="eqd6ImRMcVfw5JcheQEkt9lDeVrr6eC7s" Subject: Re: [Qemu-devel] [PATCH V7 04/13] monitor: avoid use of global *cur_mon in monitor_find_completion() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: armbru@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --eqd6ImRMcVfw5JcheQEkt9lDeVrr6eC7s Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/19/2013 07:44 PM, Wenchao Xia wrote: > Parameter *mon is added, and local variable *mon added in previous patc= h > is removed. The caller readline_completion(), pass rs->mon as value, wh= ich > should be initialized in readline_init() called by monitor_init(). >=20 > Signed-off-by: Wenchao Xia > --- > include/monitor/readline.h | 3 ++- > monitor.c | 18 +++++++++--------- > readline.c | 2 +- > 3 files changed, 12 insertions(+), 11 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --eqd6ImRMcVfw5JcheQEkt9lDeVrr6eC7s Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJR6nw9AAoJEKeha0olJ0Nq1bIIAKqYWtXhhoTtUYNaajSf6xB+ yFobkTpqPfIv0/Eg8JBRejztYFbRJQe6FDKrDRo/tR4YVQgbJysM/EW7LwN6JKaJ OWZq9+zaJwFHdPG+vWBAlUkrKM2NT9ttj3AmLnkwFNFog7j3R0JV7ITgG7TrZAiA hHgoxLGIwdev/szsLdBkkGMthPsDTi+QTpinR8Ss36Umi9N99ozf16Fa3x1waYYS ILU0wwDJBtHty7bU5sDeBQM1ajD0+4oMOPYcgS9JBDoOJMvvLlAywqflFfkXfcgC sBdKMHs1dNdfQuBZ6HvHZ9q1OrDKAyfBNDHh6CBzrZoxKLZ60g8+ZuSbb5ten/o= =r0pr -----END PGP SIGNATURE----- --eqd6ImRMcVfw5JcheQEkt9lDeVrr6eC7s--