From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44888) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V0VtY-0006ix-0M for qemu-devel@nongnu.org; Sat, 20 Jul 2013 08:04:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V0VtX-0007yQ-3e for qemu-devel@nongnu.org; Sat, 20 Jul 2013 08:04:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20629) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V0VtW-0007yL-QX for qemu-devel@nongnu.org; Sat, 20 Jul 2013 08:04:15 -0400 Message-ID: <51EA7CBB.6090406@redhat.com> Date: Sat, 20 Jul 2013 06:04:11 -0600 From: Eric Blake MIME-Version: 1.0 References: <1374284656-12025-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1374284656-12025-7-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1374284656-12025-7-git-send-email-xiawenc@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="EHbnijpto4PdJnvTqaDOHCjr9bkKtoT7b" Subject: Re: [Qemu-devel] [PATCH V7 06/13] monitor: avoid direct use of global variable *mon_cmds List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: armbru@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --EHbnijpto4PdJnvTqaDOHCjr9bkKtoT7b Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/19/2013 07:44 PM, Wenchao Xia wrote: > New member *cmd_table is added in structure Monitor to avoid direct usa= ge of > *mon_cmds. Now monitor have an associated command table, when global va= riable > *info_cmds is also discarded, structure Monitor would gain full control= about > how to deal with user input. >=20 > Signed-off-by: Wenchao Xia > --- > monitor.c | 14 +++++++++----- > 1 files changed, 9 insertions(+), 5 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --EHbnijpto4PdJnvTqaDOHCjr9bkKtoT7b Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJR6ny7AAoJEKeha0olJ0NqLEQIAIxZ+WWHHoXfw93J20gVB+cW tuzDoNysNHGVdLrjTklwga53o1jBzIZGxLf3GUjeXhyZnT2I3RTcW/VLTEHK+WSD 3bwvoATmp/35Ez0bxg+44ilGH1h27UXLgDaOWhpuHTu1i7EMBnDxbc5QvgszQ6XA WkK0olb/ZxJchNP8/aD46WAdhX90d2wVWg7/TuWTVXaPpwgqxiKc6dFtEAKXFSCu lEl8gVg0ePrmF8ol5NXynlKneKSk5Zb7KUB6qb/Z3VCMqLyLH7jwHLSt3armTdtD ykE/zPjIjWWZhtFnxQJnHgewVAMpWPgU5NzqcyQ5yXtueB4jupepruSXFGA0C/Q= =5zcB -----END PGP SIGNATURE----- --EHbnijpto4PdJnvTqaDOHCjr9bkKtoT7b--