From: Eric Blake <eblake@redhat.com>
To: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Cc: armbru@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org,
lcapitulino@redhat.com
Subject: Re: [Qemu-devel] [PATCH V7 07/13] monitor: code move for parse_cmdline()
Date: Sat, 20 Jul 2013 06:25:00 -0600 [thread overview]
Message-ID: <51EA819C.9030202@redhat.com> (raw)
In-Reply-To: <1374284656-12025-8-git-send-email-xiawenc@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 595 bytes --]
On 07/19/2013 07:44 PM, Wenchao Xia wrote:
> help_cmd() need this function later, so move it. get_str() is called by
> parse_cmdline() so it is moved also. Some code style error reported by
> check script, is also fixed.
>
> Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
> ---
> monitor.c | 191 +++++++++++++++++++++++++++++++------------------------------
> 1 files changed, 98 insertions(+), 93 deletions(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
next prev parent reply other threads:[~2013-07-20 12:25 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-20 1:44 [Qemu-devel] [PATCH V7 00/13] monitor: support sub command group in auto completion and help Wenchao Xia
2013-07-20 1:44 ` [Qemu-devel] [PATCH V7 01/13] monitor: avoid use of global *cur_mon in cmd_completion() Wenchao Xia
2013-07-20 11:49 ` Eric Blake
2013-07-20 13:13 ` Wenchao Xia
2013-07-20 1:44 ` [Qemu-devel] [PATCH V7 02/13] monitor: avoid use of global *cur_mon in file_completion() Wenchao Xia
2013-07-20 11:58 ` Eric Blake
2013-07-20 1:44 ` [Qemu-devel] [PATCH V7 03/13] monitor: avoid use of global *cur_mon in block_completion_it() Wenchao Xia
2013-07-20 11:59 ` Eric Blake
2013-07-20 1:44 ` [Qemu-devel] [PATCH V7 04/13] monitor: avoid use of global *cur_mon in monitor_find_completion() Wenchao Xia
2013-07-20 12:02 ` Eric Blake
2013-07-20 1:44 ` [Qemu-devel] [PATCH V7 05/13] monitor: avoid use of global *cur_mon in readline_completion() Wenchao Xia
2013-07-20 12:03 ` Eric Blake
2013-07-20 1:44 ` [Qemu-devel] [PATCH V7 06/13] monitor: avoid direct use of global variable *mon_cmds Wenchao Xia
2013-07-20 12:04 ` Eric Blake
2013-07-20 1:44 ` [Qemu-devel] [PATCH V7 07/13] monitor: code move for parse_cmdline() Wenchao Xia
2013-07-20 12:25 ` Eric Blake [this message]
2013-07-20 1:44 ` [Qemu-devel] [PATCH V7 08/13] monitor: refine parse_cmdline() Wenchao Xia
2013-07-20 12:27 ` Eric Blake
2013-07-20 1:44 ` [Qemu-devel] [PATCH V7 09/13] monitor: support sub command in help Wenchao Xia
2013-07-24 22:46 ` Eric Blake
2013-07-20 1:44 ` [Qemu-devel] [PATCH V7 10/13] monitor: refine monitor_find_completion() Wenchao Xia
2013-07-25 15:56 ` Eric Blake
2013-07-20 1:44 ` [Qemu-devel] [PATCH V7 11/13] monitor: support sub command in auto completion Wenchao Xia
2013-07-25 16:26 ` Eric Blake
2013-07-20 1:44 ` [Qemu-devel] [PATCH V7 12/13] monitor: allow "help" show message for single command in sub group Wenchao Xia
2013-07-25 16:39 ` Eric Blake
2013-07-20 1:44 ` [Qemu-devel] [PATCH V7 13/13] monitor: improve auto complete of "help" " Wenchao Xia
2013-07-25 16:51 ` Eric Blake
2013-07-24 13:26 ` [Qemu-devel] [PATCH V7 00/13] monitor: support sub command group in auto completion and help Wenchao Xia
2013-07-26 3:22 ` Wenchao Xia
2013-07-29 14:01 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51EA819C.9030202@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=xiawenc@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).