From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50431) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V0WGX-0003Os-Sl for qemu-devel@nongnu.org; Sat, 20 Jul 2013 08:28:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V0WGW-0007Dj-R2 for qemu-devel@nongnu.org; Sat, 20 Jul 2013 08:28:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:61993) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V0WGW-0007DI-Jr for qemu-devel@nongnu.org; Sat, 20 Jul 2013 08:28:00 -0400 Message-ID: <51EA824D.20906@redhat.com> Date: Sat, 20 Jul 2013 06:27:57 -0600 From: Eric Blake MIME-Version: 1.0 References: <1374284656-12025-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1374284656-12025-9-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1374284656-12025-9-git-send-email-xiawenc@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="XnmMTecT2TtxPK8wWlvMPhTFf2l2e0r1M" Subject: Re: [Qemu-devel] [PATCH V7 08/13] monitor: refine parse_cmdline() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: armbru@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --XnmMTecT2TtxPK8wWlvMPhTFf2l2e0r1M Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/19/2013 07:44 PM, Wenchao Xia wrote: > Since this function will be used by help_cmd() later, so improve > it to make it more generic and easier to use. free_cmdline_args() > is added to as paired function to free the result. s/added to/added too/ >=20 > One change of this function is that, when the valid args in input > exceed the limit of MAX_ARGS, it fails now, instead of return with > MAX_ARGS of parsed args in old code. This should not impact much > since it is rare that user input many args in monitor's "help" and > auto complete scenario. >=20 > Signed-off-by: Wenchao Xia > --- > monitor.c | 51 ++++++++++++++++++++++++++++++++++++++++----------- > 1 files changed, 40 insertions(+), 11 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --XnmMTecT2TtxPK8wWlvMPhTFf2l2e0r1M Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJR6oJNAAoJEKeha0olJ0NqaOUH/0b1HymljimDHGqH6lGv1HKy esQ1vsTQr8A/mAbe/U9elcmRkrkIXUKXdl89x8yKfr59yGySLHfDRYbi3t8jBRbc jDOpJ4B/nmOxuEW9MYPa1A/YpKbgQ/+a+lH+LSwxXU1TXMc9cLLha8z+osy2to7k V4Ar2bFAyOaMULQH1mbw/48icu4lAZo1nyU+WpySBb0PIO+3CThl+3hst4hRQF02 IL/tmnGfCvMs1VPJ2EZy5PpxCsZJlF+Hf+xw432kQ6BXC1EyXbIjosffW0url0zq b778+l3/9ThsHraKjQ0ykpfmH8OtCBi1MCoE0DtwUm7m5DtRdN7CfBsbSZGdmHs= =NjJq -----END PGP SIGNATURE----- --XnmMTecT2TtxPK8wWlvMPhTFf2l2e0r1M--