From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33804) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V0X0a-0004ZI-OW for qemu-devel@nongnu.org; Sat, 20 Jul 2013 09:15:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V0X0W-0005hI-HP for qemu-devel@nongnu.org; Sat, 20 Jul 2013 09:15:36 -0400 Received: from e28smtp06.in.ibm.com ([122.248.162.6]:59155) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V0X0V-0005ge-TK for qemu-devel@nongnu.org; Sat, 20 Jul 2013 09:15:32 -0400 Received: from /spool/local by e28smtp06.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sat, 20 Jul 2013 18:37:05 +0530 Received: from d28relay05.in.ibm.com (d28relay05.in.ibm.com [9.184.220.62]) by d28dlp03.in.ibm.com (Postfix) with ESMTP id D3DC41258043 for ; Sat, 20 Jul 2013 18:44:46 +0530 (IST) Received: from d28av04.in.ibm.com (d28av04.in.ibm.com [9.184.220.66]) by d28relay05.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r6KDFLxX26869782 for ; Sat, 20 Jul 2013 18:45:21 +0530 Received: from d28av04.in.ibm.com (loopback [127.0.0.1]) by d28av04.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r6KDFOqO030509 for ; Sat, 20 Jul 2013 23:15:24 +1000 Message-ID: <51EA8D10.4080500@linux.vnet.ibm.com> Date: Sat, 20 Jul 2013 21:13:52 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1374284656-12025-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1374284656-12025-2-git-send-email-xiawenc@linux.vnet.ibm.com> <51EA795B.6060800@redhat.com> In-Reply-To: <51EA795B.6060800@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH V7 01/13] monitor: avoid use of global *cur_mon in cmd_completion() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: armbru@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com 于 2013-7-20 19:49, Eric Blake 写道: > On 07/19/2013 07:44 PM, Wenchao Xia wrote: >> A new local variable *mon is added in monitor_find_completion() >> to make compile pass, which will be removed later in >> convertion patch for monitor_find_completion(). > > s/convertion/conversion/ > >> >> Signed-off-by: Wenchao Xia >> --- >> monitor.c | 13 +++++++------ >> 1 files changed, 7 insertions(+), 6 deletions(-) > > Reviewed-by: Eric Blake > Thanks for review. I have read the patches sometime but unfortunately have not found the spell problem, my bad. Luiz, do you have other comments for this version except the typo? If not, may I ask you for a favor to apply it and fix the typo issues Eric have pointed out? I hope avoid a re-spin for it, to disturb people less. -- Best Regards Wenchao Xia