From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38714) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1AYA-00084n-CO for qemu-devel@nongnu.org; Mon, 22 Jul 2013 03:28:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V1AY9-0005bC-Gl for qemu-devel@nongnu.org; Mon, 22 Jul 2013 03:28:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35353) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1AY9-0005b3-93 for qemu-devel@nongnu.org; Mon, 22 Jul 2013 03:28:53 -0400 Message-ID: <51ECDF77.4050104@redhat.com> Date: Mon, 22 Jul 2013 10:29:59 +0300 From: Orit Wasserman MIME-Version: 1.0 References: <1374200625-7125-1-git-send-email-p.pawit@gmail.com> In-Reply-To: <1374200625-7125-1-git-send-email-p.pawit@gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] migration: send total time in QMP at "completed" stage List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pawit Pornkitprasan Cc: Ryousei Takano , qemu-devel@nongnu.org, Juan Quintela On 07/19/2013 05:23 AM, Pawit Pornkitprasan wrote: > The "completed" stage sets total_time but not has_total_time and > thus it is not sent via QMP reply (but sent via HMP nevertheless) > > Signed-off-by: Pawit Pornkitprasan > --- > migration.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/migration.c b/migration.c > index 9f5a423..4c16f2e 100644 > --- a/migration.c > +++ b/migration.c > @@ -219,6 +219,7 @@ MigrationInfo *qmp_query_migrate(Error **errp) > > info->has_status = true; > info->status = g_strdup("completed"); > + info->has_total_time = true; > info->total_time = s->total_time; > info->has_downtime = true; > info->downtime = s->downtime; > Reviewed-by: Orit Wasserman