* [Qemu-devel] [PATCH] migration: send total time in QMP at "completed" stage
@ 2013-07-19 2:23 Pawit Pornkitprasan
2013-07-19 10:56 ` Eric Blake
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Pawit Pornkitprasan @ 2013-07-19 2:23 UTC (permalink / raw)
To: qemu-devel; +Cc: Pawit Pornkitprasan, Ryousei Takano, Juan Quintela
The "completed" stage sets total_time but not has_total_time and
thus it is not sent via QMP reply (but sent via HMP nevertheless)
Signed-off-by: Pawit Pornkitprasan <p.pawit@gmail.com>
---
migration.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/migration.c b/migration.c
index 9f5a423..4c16f2e 100644
--- a/migration.c
+++ b/migration.c
@@ -219,6 +219,7 @@ MigrationInfo *qmp_query_migrate(Error **errp)
info->has_status = true;
info->status = g_strdup("completed");
+ info->has_total_time = true;
info->total_time = s->total_time;
info->has_downtime = true;
info->downtime = s->downtime;
--
1.8.1.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] migration: send total time in QMP at "completed" stage
2013-07-19 2:23 [Qemu-devel] [PATCH] migration: send total time in QMP at "completed" stage Pawit Pornkitprasan
@ 2013-07-19 10:56 ` Eric Blake
2013-07-22 7:29 ` Orit Wasserman
2013-07-29 19:02 ` Luiz Capitulino
2 siblings, 0 replies; 4+ messages in thread
From: Eric Blake @ 2013-07-19 10:56 UTC (permalink / raw)
To: Pawit Pornkitprasan; +Cc: Ryousei Takano, qemu-devel, Juan Quintela
[-- Attachment #1: Type: text/plain, Size: 930 bytes --]
On 07/18/2013 08:23 PM, Pawit Pornkitprasan wrote:
> The "completed" stage sets total_time but not has_total_time and
> thus it is not sent via QMP reply (but sent via HMP nevertheless)
>
> Signed-off-by: Pawit Pornkitprasan <p.pawit@gmail.com>
> ---
> migration.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> diff --git a/migration.c b/migration.c
> index 9f5a423..4c16f2e 100644
> --- a/migration.c
> +++ b/migration.c
> @@ -219,6 +219,7 @@ MigrationInfo *qmp_query_migrate(Error **errp)
>
> info->has_status = true;
> info->status = g_strdup("completed");
> + info->has_total_time = true;
> info->total_time = s->total_time;
> info->has_downtime = true;
> info->downtime = s->downtime;
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] migration: send total time in QMP at "completed" stage
2013-07-19 2:23 [Qemu-devel] [PATCH] migration: send total time in QMP at "completed" stage Pawit Pornkitprasan
2013-07-19 10:56 ` Eric Blake
@ 2013-07-22 7:29 ` Orit Wasserman
2013-07-29 19:02 ` Luiz Capitulino
2 siblings, 0 replies; 4+ messages in thread
From: Orit Wasserman @ 2013-07-22 7:29 UTC (permalink / raw)
To: Pawit Pornkitprasan; +Cc: Ryousei Takano, qemu-devel, Juan Quintela
On 07/19/2013 05:23 AM, Pawit Pornkitprasan wrote:
> The "completed" stage sets total_time but not has_total_time and
> thus it is not sent via QMP reply (but sent via HMP nevertheless)
>
> Signed-off-by: Pawit Pornkitprasan <p.pawit@gmail.com>
> ---
> migration.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/migration.c b/migration.c
> index 9f5a423..4c16f2e 100644
> --- a/migration.c
> +++ b/migration.c
> @@ -219,6 +219,7 @@ MigrationInfo *qmp_query_migrate(Error **errp)
>
> info->has_status = true;
> info->status = g_strdup("completed");
> + info->has_total_time = true;
> info->total_time = s->total_time;
> info->has_downtime = true;
> info->downtime = s->downtime;
>
Reviewed-by: Orit Wasserman <owasserm@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] migration: send total time in QMP at "completed" stage
2013-07-19 2:23 [Qemu-devel] [PATCH] migration: send total time in QMP at "completed" stage Pawit Pornkitprasan
2013-07-19 10:56 ` Eric Blake
2013-07-22 7:29 ` Orit Wasserman
@ 2013-07-29 19:02 ` Luiz Capitulino
2 siblings, 0 replies; 4+ messages in thread
From: Luiz Capitulino @ 2013-07-29 19:02 UTC (permalink / raw)
To: Pawit Pornkitprasan; +Cc: Ryousei Takano, qemu-devel, Juan Quintela
On Fri, 19 Jul 2013 11:23:45 +0900
Pawit Pornkitprasan <p.pawit@gmail.com> wrote:
> The "completed" stage sets total_time but not has_total_time and
> thus it is not sent via QMP reply (but sent via HMP nevertheless)
>
> Signed-off-by: Pawit Pornkitprasan <p.pawit@gmail.com>
Applied to the qmp branch, thanks.
> ---
> migration.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/migration.c b/migration.c
> index 9f5a423..4c16f2e 100644
> --- a/migration.c
> +++ b/migration.c
> @@ -219,6 +219,7 @@ MigrationInfo *qmp_query_migrate(Error **errp)
>
> info->has_status = true;
> info->status = g_strdup("completed");
> + info->has_total_time = true;
> info->total_time = s->total_time;
> info->has_downtime = true;
> info->downtime = s->downtime;
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-07-29 19:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-19 2:23 [Qemu-devel] [PATCH] migration: send total time in QMP at "completed" stage Pawit Pornkitprasan
2013-07-19 10:56 ` Eric Blake
2013-07-22 7:29 ` Orit Wasserman
2013-07-29 19:02 ` Luiz Capitulino
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).