From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39516) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1Aab-0000sN-R1 for qemu-devel@nongnu.org; Mon, 22 Jul 2013 03:31:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V1Aaa-0006fi-S8 for qemu-devel@nongnu.org; Mon, 22 Jul 2013 03:31:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21412) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1Aaa-0006fc-Kk for qemu-devel@nongnu.org; Mon, 22 Jul 2013 03:31:24 -0400 Message-ID: <51ECE00E.3050209@redhat.com> Date: Mon, 22 Jul 2013 10:32:30 +0300 From: Orit Wasserman MIME-Version: 1.0 References: <1374201401-11244-1-git-send-email-p.pawit@gmail.com> In-Reply-To: <1374201401-11244-1-git-send-email-p.pawit@gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] migration: don't use uninitialized variables List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pawit Pornkitprasan Cc: Ryousei Takano , qemu-devel@nongnu.org, Juan Quintela On 07/19/2013 05:36 AM, Pawit Pornkitprasan wrote: > The qmp_migrate method uses the 'blk' and 'inc' parameter without > checking if they're valid or not (they may be uninitialized if > command is received via QMP) > > Signed-off-by: Pawit Pornkitprasan > --- > migration.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/migration.c b/migration.c > index 9f5a423..f3d1ff7 100644 > --- a/migration.c > +++ b/migration.c > @@ -385,8 +385,8 @@ void qmp_migrate(const char *uri, bool has_blk, bool blk, > MigrationParams params; > const char *p; > > - params.blk = blk; > - params.shared = inc; > + params.blk = has_blk && blk; > + params.shared = has_inc && inc; > > if (s->state == MIG_STATE_ACTIVE) { > error_set(errp, QERR_MIGRATION_ACTIVE); > Reviewed-by: Orit Wasserman