From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50385)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V1DV4-0005M2-Pc
	for qemu-devel@nongnu.org; Mon, 22 Jul 2013 06:38:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V1DV1-00078M-DO
	for qemu-devel@nongnu.org; Mon, 22 Jul 2013 06:37:54 -0400
Received: from cantor2.suse.de ([195.135.220.15]:45218 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V1DV1-00078A-5e
	for qemu-devel@nongnu.org; Mon, 22 Jul 2013 06:37:51 -0400
Message-ID: <51ED0B7A.2010205@suse.de>
Date: Mon, 22 Jul 2013 12:37:46 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1374483382-12141-1-git-send-email-proljc@gmail.com>
	<1374483382-12141-5-git-send-email-proljc@gmail.com>
	<CAFEAcA_Ai0RkvD2vkVFXZ5HSP6+cMBzBRSxHhahyCiacZvJZxg@mail.gmail.com>
	<CAJBMM-t3Eixoc6OW0PzTK20VU1fL2_qVeHyZFhs0o-BakDEMbg@mail.gmail.com>
	<CAFEAcA-75cp9GtZbWPCM=sDW+dHmu7pRNhEUmQZS=5ZnVqTk7Q@mail.gmail.com>
In-Reply-To: <CAFEAcA-75cp9GtZbWPCM=sDW+dHmu7pRNhEUmQZS=5ZnVqTk7Q@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v3 4/4] target-openrisc: Fix cpu_model by
 name
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Jia Liu <proljc@gmail.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

Am 22.07.2013 11:43, schrieb Peter Maydell:
> On 22 July 2013 10:42, Jia Liu <proljc@gmail.com> wrote:
>> Hi Andreas and Peter,
>>
>> On Mon, Jul 22, 2013 at 5:29 PM, Peter Maydell <peter.maydell@linaro.o=
rg> wrote:
>>> This looks a bit odd. The commit message suggests it's an
>>> attempt to fix the bug that was fixed by commit 071b3364e --
>>> is it really needed? Andreas?
>>
>> commit 071b3364e fix the typename only, but this one make "-cpu any"
>> "-cpu or1200" "-cpu any-or32-cpu" "-cpu or1200-or32-cpu" working fine.
>=20
> The last two of these would be wrong: -cpu should only
> accept CPU names, ie "any" or "or1200".

Peter, the story is that due to an oversight on my part, it was possible
to use -cpu or1200-or32-cpu only for some weeks or months. This has been
fixed so that only -cpu or1200 works.

It is up to Jia whether he sees a need to have both work or whether -cpu
or1200 would be sufficient. In any case, I was not CC'ed on this series,
so I only came across one patch by accident during a search for
something else. ;)

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg