From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38609)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V1E7K-0008N3-9A
	for qemu-devel@nongnu.org; Mon, 22 Jul 2013 07:17:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V1E7F-0004H3-AQ
	for qemu-devel@nongnu.org; Mon, 22 Jul 2013 07:17:26 -0400
Received: from cantor2.suse.de ([195.135.220.15]:46964 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V1E7F-0004Gx-2U
	for qemu-devel@nongnu.org; Mon, 22 Jul 2013 07:17:21 -0400
Message-ID: <51ED14BD.8050406@suse.de>
Date: Mon, 22 Jul 2013 13:17:17 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1374483382-12141-1-git-send-email-proljc@gmail.com>
	<1374483382-12141-5-git-send-email-proljc@gmail.com>
	<CAFEAcA_Ai0RkvD2vkVFXZ5HSP6+cMBzBRSxHhahyCiacZvJZxg@mail.gmail.com>
	<CAJBMM-t3Eixoc6OW0PzTK20VU1fL2_qVeHyZFhs0o-BakDEMbg@mail.gmail.com>
	<CAFEAcA-75cp9GtZbWPCM=sDW+dHmu7pRNhEUmQZS=5ZnVqTk7Q@mail.gmail.com>
	<51ED0B7A.2010205@suse.de>
	<CAFEAcA-kV29SAFw4b4sWwnLk5Ud2hi8f-L4WQ6N5Q-1e5tVn9A@mail.gmail.com>
In-Reply-To: <CAFEAcA-kV29SAFw4b4sWwnLk5Ud2hi8f-L4WQ6N5Q-1e5tVn9A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v3 4/4] target-openrisc: Fix cpu_model by
 name
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Richard Henderson <rth@twiddle.net>, Jia Liu <proljc@gmail.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

Am 22.07.2013 12:40, schrieb Peter Maydell:
> On 22 July 2013 11:37, Andreas F=C3=A4rber <afaerber@suse.de> wrote:
>> Am 22.07.2013 11:43, schrieb Peter Maydell:
>>>> commit 071b3364e fix the typename only, but this one make "-cpu any"
>>>> "-cpu or1200" "-cpu any-or32-cpu" "-cpu or1200-or32-cpu" working fin=
e.
>>>
>>> The last two of these would be wrong: -cpu should only
>>> accept CPU names, ie "any" or "or1200".
>>
>> Peter, the story is that due to an oversight on my part, it was possib=
le
>> to use -cpu or1200-or32-cpu only for some weeks or months. This has be=
en
>> fixed so that only -cpu or1200 works.
>=20
> Yep; my view is that the acceptance of the -or32-cpu varieties
> was a bug which we have now fixed. In any case we should be
> consistent across target architectures about what we allow.
> I'm happy with the approach Jia has taken of just dropping
> this patch in v4 of this series.

alpha allows both, but -cpu ? just gave me a segfault. :/
It didn't have -cpu ? before QOM, so we decided to print the type names
there. Will need to investigate what's going wrong currently.

Stripping -alpha-cpu off typenames would surely be possible.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg