From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57592) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1LGu-0003O7-EN for qemu-devel@nongnu.org; Mon, 22 Jul 2013 14:55:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V1LGt-0002wq-8J for qemu-devel@nongnu.org; Mon, 22 Jul 2013 14:55:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48544) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1LGs-0002wa-P0 for qemu-devel@nongnu.org; Mon, 22 Jul 2013 14:55:47 -0400 Message-ID: <51ED802D.3020207@redhat.com> Date: Mon, 22 Jul 2013 12:55:41 -0600 From: Eric Blake MIME-Version: 1.0 References: <1374327070-11400-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1374327070-11400-2-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1374327070-11400-2-git-send-email-xiawenc@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="s4MbrNUp1i3kbrEglh7KvUxe8TfSJPmre" Subject: Re: [Qemu-devel] [PATCH V6 1/8] snapshot: new function bdrv_snapshot_find_by_id_and_name() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: kwolf@redhat.com, phrdina@redhat.com, famz@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, stefanha@redhat.com, pbonzini@redhat.com, dietmar@proxmox.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --s4MbrNUp1i3kbrEglh7KvUxe8TfSJPmre Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/20/2013 07:31 AM, Wenchao Xia wrote: > To make it clear about id and name in searching, add this API > to distinguish them. Caller can choose to search by id or name, > *errp will be set only for exception. >=20 > Some code are modified based on Pavel's patch. >=20 > Signed-off-by: Wenchao Xia > Signed-off-by: Pavel Hrdina > --- > block/snapshot.c | 73 ++++++++++++++++++++++++++++++++++++++= ++++++++ > include/block/snapshot.h | 6 ++++ > 2 files changed, 79 insertions(+), 0 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --s4MbrNUp1i3kbrEglh7KvUxe8TfSJPmre Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJR7YAuAAoJEKeha0olJ0NqJWUH/RSvParrXeqSbqlZWoMqFf9b OPkGUIPpejQhnWzfk3slxxtMYJs4Ouz7sory5brtW4r4lmPP2S61cDfa5+Bk9dCn SmeUVfXWi1kFKD8JTGnVDb5zLjgxTEvrfR9lgIHcsBLwwG6cXOrdWUQ39cW4iq/2 58vOnbHdjTnxVwGTEc5Zd9p8jIdWCl02Gw074ORBYSB0cWJRo3nQFg6zrEQvpnPj C33A0qK0iGdVTZa7OmQbmldnfluLluxTQT5Wa+CQSJU9IT1ZA0Giw8eIlQWyEFh9 LGrXYb8gJSMkleZOqiGgtoIDqP/x3TvSuzLt4sCOeKqi5HtdRbC2g6YhIZ/MBnY= =xo0M -----END PGP SIGNATURE----- --s4MbrNUp1i3kbrEglh7KvUxe8TfSJPmre--