From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35131) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1ODK-0007qw-0F for qemu-devel@nongnu.org; Mon, 22 Jul 2013 18:04:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V1ODI-0004GJ-SB for qemu-devel@nongnu.org; Mon, 22 Jul 2013 18:04:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49077) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1ODI-0004GF-KE for qemu-devel@nongnu.org; Mon, 22 Jul 2013 18:04:16 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6MM4FcR024743 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 22 Jul 2013 18:04:16 -0400 Message-ID: <51EDAC5F.1070001@redhat.com> Date: Mon, 22 Jul 2013 16:04:15 -0600 From: Eric Blake MIME-Version: 1.0 References: <1374527256-27631-1-git-send-email-lersek@redhat.com> <1374527256-27631-9-git-send-email-lersek@redhat.com> In-Reply-To: <1374527256-27631-9-git-send-email-lersek@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6uCCm6guEEbplpNbhbijwgST55nW36OOQ" Subject: Re: [Qemu-devel] [PATCH 8/8] OptsVisitor: introduce unit tests, with test cases for range flattening List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --6uCCm6guEEbplpNbhbijwgST55nW36OOQ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/22/2013 03:07 PM, Laszlo Ersek wrote: > Signed-off-by: Laszlo Ersek > --- > tests/Makefile | 6 +- > qapi-schema-test.json | 15 +++ > tests/test-opts-visitor.c | 275 +++++++++++++++++++++++++++++++++++++= ++++++++ > .gitignore | 1 + > 4 files changed, 296 insertions(+), 1 deletions(-) > create mode 100644 tests/test-opts-visitor.c > + add_test("/visitor/opts/i64/val1/errno", &expect_fail, > + "i64=3D0x8000000000000000"); > + add_test("/visitor/opts/i64/val1/empty", &expect_fail, "i64=3D"= ); > + add_test("/visitor/opts/i64/val1/trailing", &expect_fail, "i64=3D5= z"); > + add_test("/visitor/opts/i64/nonlist", &expect_fail, "i64x=3D= 5-6"); > + add_test("/visitor/opts/i64/val2/errno", &expect_fail, > + "i64=3D0x7fffffffffffffff-0x8000000000000000"); > + add_test("/visitor/opts/i64/val2/empty", &expect_fail, "i64=3D5= -"); > + add_test("/visitor/opts/i64/val2/trailing", &expect_fail, "i64=3D5= -6z"); > + add_test("/visitor/opts/i64/range/empty", &expect_fail, "i64=3D6= -5"); > + add_test("/visitor/opts/i64/range/minval", &expect_i64_min, > + "i64=3D-0x8000000000000000--0x8000000000000000"); > + add_test("/visitor/opts/i64/range/maxval", &expect_i64_max, > + "i64=3D0x7fffffffffffffff-0x7fffffffffffffff"); Pretty thorough, although I thought of a couple other ideas to test: i64=3D5z-6 should fail; i64=3D5-6-7 should fail --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --6uCCm6guEEbplpNbhbijwgST55nW36OOQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJR7axfAAoJEKeha0olJ0NqyuAH/33skBZqyy4wqJ7CRR3CU044 qqVWEZ7PSVZv2dRGmkbcawRHwfsBNKDw6Xox6ECuPYFmaHP87wAhKDvZFmZIijTs Ct/nUGQMBFAJF8AMzAYlBwk3wW3DehTUSPPea3mt+5uGbq1yuTE/GAaJBuDX4g7t TTNLd8QFCJNzjpyJ5pfUzkV+wxN9lOK68b5PMdgAvxPNJML6C5B/bNAlCqZWcdvI W5Ci/ytF6R8+QRuva+X07lGCoxmvLNve28pIGjzzg6vnrpZyOcW/ONm8P1AaRbiW zZbVyfWb1xmW++gJ410zV+hiOAroFT4eBxWKlza94Y/0FSwKC89pAHoPZzep+i8= =sPDm -----END PGP SIGNATURE----- --6uCCm6guEEbplpNbhbijwgST55nW36OOQ--