From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35597) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1OEx-0001cp-ML for qemu-devel@nongnu.org; Mon, 22 Jul 2013 18:06:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V1OEw-000572-6C for qemu-devel@nongnu.org; Mon, 22 Jul 2013 18:05:59 -0400 Received: from cantor2.suse.de ([195.135.220.15]:43565 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1OEv-00056s-Vv for qemu-devel@nongnu.org; Mon, 22 Jul 2013 18:05:58 -0400 Message-ID: <51EDACC0.1060208@suse.de> Date: Tue, 23 Jul 2013 00:05:52 +0200 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1374415744-6675-1-git-send-email-afaerber@suse.de> <20130721202644.GB15187@redhat.com> <51ED6A41.6000108@suse.de> In-Reply-To: <51ED6A41.6000108@suse.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH RFC qom-next 0/4] QOM'ification of pci-bridge types List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Paolo Bonzini , Peter Crosthwaite , qemu-devel@nongnu.org, Anthony Liguori , Hu Tao Am 22.07.2013 19:22, schrieb Andreas F=E4rber: > Am 21.07.2013 22:26, schrieb Michael S. Tsirkin: >> On Sun, Jul 21, 2013 at 04:09:00PM +0200, Andreas F=E4rber wrote: >>> Hello Michael et al., >>> >>> This series turns PCIBridge, PCIEPort and PCIESlot into abstract QOM = types, >>> so that we can use QOM casts to obtain a pointer. >>> >>> Possibly this was prompted by q35's PCIe? >> >> What was prompted? >=20 > This refactoring series. >=20 >> What's the question exactly? >=20 > Why I prepared this series on an offline train ride on Wednesday. ;) No= t > for you to answer - something PCIe must've gotten in the way of some QO= M > realize conversion but the branch is missing the final patch showing > what these types and casts are good for. Doh, stumbled over it again: pci_bridge_initfn() should become PCIBridge's realizefn, and walking down the type hierarchy pcie_port_init_reg() should become PCIEPort's (which needs TYPE_PCIE_PORT), etc. That's a bigger refactoring though, so v2 will come without it. Andreas > Since we're in Soft Freeze I > rather wanted to flush my queues for review though rather than spend > more time puzzling why I did this. :) >=20 > Andreas >=20 >> >>> Don't remember ATM... >>> >>> Regards, >>> Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg