From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44082)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V1Qos-0006nj-Mo
	for qemu-devel@nongnu.org; Mon, 22 Jul 2013 20:51:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V1Qor-0007G1-Ma
	for qemu-devel@nongnu.org; Mon, 22 Jul 2013 20:51:14 -0400
Received: from cantor2.suse.de ([195.135.220.15]:47443 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V1Qor-0007Fx-Ge
	for qemu-devel@nongnu.org; Mon, 22 Jul 2013 20:51:13 -0400
Message-ID: <51EDD37D.305@suse.de>
Date: Tue, 23 Jul 2013 02:51:09 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1374510975-9896-1-git-send-email-afaerber@suse.de>
	<CAFEAcA_X1XedQvKnoLJGu7KuASNM8NykW84vSxc3EQWkKfEjTw@mail.gmail.com>
	<51ED6C90.2060101@suse.de>
	<CAFEAcA92NYw4zNaYkHpF79tsLDsybxqJ-zRxwzUBer16UhiiWw@mail.gmail.com>
In-Reply-To: <CAFEAcA92NYw4zNaYkHpF79tsLDsybxqJ-zRxwzUBer16UhiiWw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH qom-cpu] HACKING: Document vaddr type usage
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org

Am 22.07.2013 19:36, schrieb Peter Maydell:
> On 22 July 2013 18:32, Andreas F=C3=A4rber <afaerber@suse.de> wrote:
>> Am 22.07.2013 19:27, schrieb Peter Maydell:
>>> Here's my suggestion for this paragraph (ie to replace
>>> both the "Use target_ulong..." and "Use vaddr" sentences
>>> above):
>>>
>>> =3D=3D=3Dbegin=3D=3D=3D
>>> For CPU virtual addresses there are several possible types.
>>> vaddr is the best type to use to hold a CPU virtual address
>>> in target-independent code, including most devices. It is
>>
>> Thanks. What reason can you think of for using vaddr in a device?
>=20
> I put that in because the existing text says "devices should
> not need to use target_ulong" and they obviously shouldn't
> use abi_ulong, leaving only vaddr if they want to play with
> target virtual addresses. I agree that most devices shouldn't
> care about virtual addresses at all, though, so it's probably
> less confusing to just drop the ", including most devices" bit.
>=20
> PS, I dunno if this amount of text needs a signoff, but you have my
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> in case it matters.

Thanks, I've attributed it to you and applied without the devices bit:
https://github.com/afaerber/qemu-cpu/commits/qom-cpu

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg