From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37052) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1XG6-0005XJ-Q5 for qemu-devel@nongnu.org; Tue, 23 Jul 2013 03:43:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V1XG5-0001Mf-Nw for qemu-devel@nongnu.org; Tue, 23 Jul 2013 03:43:46 -0400 Received: from mail-wi0-x236.google.com ([2a00:1450:400c:c05::236]:58054) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1XG5-0001MS-HH for qemu-devel@nongnu.org; Tue, 23 Jul 2013 03:43:45 -0400 Received: by mail-wi0-f182.google.com with SMTP id m6so2704360wiv.9 for ; Tue, 23 Jul 2013 00:43:44 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <51EE341F.7040108@redhat.com> Date: Tue, 23 Jul 2013 09:43:27 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1374518017-10424-1-git-send-email-otubo@linux.vnet.ibm.com> In-Reply-To: <1374518017-10424-1-git-send-email-otubo@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCHv3 0/2] seccomp: remove unused syscalls - for 1.6 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Otubo Cc: pmoore@redhat.com, coreyb@linux.vnet.ibm.com, qemu-devel@nongnu.org Il 22/07/2013 20:33, Eduardo Otubo ha scritto: > In this small patch series I basically: > > v3 update: > - reincluded getrlimit(), it's used by Xen. > > v2 update: > - set libseccomp 2.1.0 as requirement on configure script. > - reincluded setrlimit() (used by Xen) and removed sendfile64() from > the whitelist. > > 1) Remove the ifdef's for the (not so) new libseccomp version that does a > best effort and translates x86_32 syscalls into x86_64 when possible. > > 2) Remove unused syscalls on the seccomp whitelist. For that removal, I've been > running several instances of Qemu using a script written on top of > virt-test[0]. After some weeks testing I could come up with this small list, > and safely remove them without breaking anything. > > [0] - https://github.com/autotest/virt-test/wiki > > Eduardo Otubo (2): > seccomp: no need to check arch in syscall whitelist > seccomp: removing unused syscalls gtom whitelist > > configure | 2 +- > qemu-seccomp.c | 17 ----------------- > 2 files changed, 1 insertion(+), 18 deletions(-) > Looks good. Reviewed-by: Paolo Bonzini Paolo