From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43587) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1Ykk-0001e0-7n for qemu-devel@nongnu.org; Tue, 23 Jul 2013 05:19:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V1Ykh-0003hu-T9 for qemu-devel@nongnu.org; Tue, 23 Jul 2013 05:19:30 -0400 Sender: Paolo Bonzini Message-ID: <51EE4A90.5020906@redhat.com> Date: Tue, 23 Jul 2013 11:19:12 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1374568221-23147-1-git-send-email-morita.kazutaka@lab.ntt.co.jp> <1374568221-23147-2-git-send-email-morita.kazutaka@lab.ntt.co.jp> In-Reply-To: <1374568221-23147-2-git-send-email-morita.kazutaka@lab.ntt.co.jp> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-1.6 01/11] ignore SIGPIPE in qemu-img and qemu-io List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: MORITA Kazutaka Cc: Kevin Wolf , sheepdog@lists.wpkg.org, qemu-devel@nongnu.org, Stefan Hajnoczi , qemu-stable@nongnu.org Il 23/07/2013 10:30, MORITA Kazutaka ha scritto: > This prevents the tools from being stopped when they write data to a > closed connection in the other side. > > Signed-off-by: MORITA Kazutaka > --- > qemu-img.c | 4 ++++ > qemu-io.c | 4 ++++ > 2 files changed, 8 insertions(+) > > diff --git a/qemu-img.c b/qemu-img.c > index c55ca5c..919d464 100644 > --- a/qemu-img.c > +++ b/qemu-img.c > @@ -2319,6 +2319,10 @@ int main(int argc, char **argv) > const img_cmd_t *cmd; > const char *cmdname; > > +#ifdef CONFIG_POSIX > + signal(SIGPIPE, SIG_IGN); > +#endif > + > error_set_progname(argv[0]); > > qemu_init_main_loop(); > diff --git a/qemu-io.c b/qemu-io.c > index cb9def5..d54dc86 100644 > --- a/qemu-io.c > +++ b/qemu-io.c > @@ -335,6 +335,10 @@ int main(int argc, char **argv) > int opt_index = 0; > int flags = BDRV_O_UNMAP; > > +#ifdef CONFIG_POSIX > + signal(SIGPIPE, SIG_IGN); > +#endif > + > progname = basename(argv[0]); > > while ((c = getopt_long(argc, argv, sopt, lopt, &opt_index)) != -1) { > Reviewed-by: Paolo Bonzini and adding qemu-stable for this one.