From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57796)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V1ZU9-0000jw-3S
	for qemu-devel@nongnu.org; Tue, 23 Jul 2013 06:06:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V1ZU7-00042P-TS
	for qemu-devel@nongnu.org; Tue, 23 Jul 2013 06:06:25 -0400
Received: from cantor2.suse.de ([195.135.220.15]:33954 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V1ZU7-00042K-N6
	for qemu-devel@nongnu.org; Tue, 23 Jul 2013 06:06:23 -0400
Message-ID: <51EE559A.4090700@suse.de>
Date: Tue, 23 Jul 2013 12:06:18 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1374571996-9228-1-git-send-email-m.hamayun@virtualopensystems.com>
	<1374571996-9228-3-git-send-email-m.hamayun@virtualopensystems.com>
	<51EE5030.3080907@suse.de>
	<CAFEAcA8F8sQkW0TDWKCVVzW_V-B=nx-5qqKrCjh1iug-ehGYMA@mail.gmail.com>
In-Reply-To: <CAFEAcA8F8sQkW0TDWKCVVzW_V-B=nx-5qqKrCjh1iug-ehGYMA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2 2/7] Add the additional parent parameter
 to memory region init calls
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: tech@virtualopensystems.com, qemu-devel@nongnu.org, "Mian M. Hamayun" <m.hamayun@virtualopensystems.com>, kvmarm@lists.cs.columbia.edu

Am 23.07.2013 12:00, schrieb Peter Maydell:
> On 23 July 2013 10:43, Andreas F=C3=A4rber <afaerber@suse.de> wrote:
>> Am 23.07.2013 11:33, schrieb Mian M. Hamayun:
>>> From: "Mian M. Hamayun" <m.hamayun@virtualopensystems.com>
>>>
>>> The memory region init calls require an additional parent parameter, =
so
>>> introduce a null parent parameter to make it happy.
>>>
>>> Signed-off-by: Mian M. Hamayun <m.hamayun@virtualopensystems.com>
>>
>> This is not OK for something labelled "PATCH". Patch series need to be
>> bisectable, not fixing up earlier patch series that have not been
>> applied yet.
>=20
> I have a rebased version of John's mach-virt patch which includes
> these fixes; I haven't sent it out yet because I've still been
> pondering whether the "create device tree nodes for everything"
> code can be made less ugly...

I'd also appreciate if you would update cpu/a57core.c wrt the container
MemoryRegion and QOM realize (still a SysBus initfn here) - that was the
intent of my a15mpcore patches I cc'ed all aarch64 people on.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg