From: "Andreas Färber" <afaerber@suse.de>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>,
qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>,
Juan Quintela <quintela@redhat.com>
Subject: Re: [Qemu-devel] [PATCH RFC qom-next 4/4] pcie_port: Turn PCIEPort and PCIESlot into abstract QOM types
Date: Tue, 23 Jul 2013 12:21:51 +0200 [thread overview]
Message-ID: <51EE593F.4090101@suse.de> (raw)
In-Reply-To: <20130723095954.GA23217@redhat.com>
Am 23.07.2013 11:59, schrieb Michael S. Tsirkin:
> On Tue, Jul 23, 2013 at 11:10:45AM +0200, Andreas Färber wrote:
>> Am 23.07.2013 09:07, schrieb Michael S. Tsirkin:
>>> On Mon, Jul 22, 2013 at 11:04:49PM +0200, Andreas Färber wrote:
>>>> For VMState I believe the real follow-up fix would be mst defining a
>>>> central macro VMSTATE_PCI_DEVICE_AER_LOG() operating on PCIDevice.
>>>> Why is that separate from VMSTATE_PCI_DEVICE() or VMSTATE_PCIE_DEVICE()
>>>> in the first place?
>
> I think the answer is that most pcie devices
> don't implement AER. AFAIK PCI devices can't
> support AER at all.
Okay, so if it's just PCIe, then XHCI is the oddball preventing moving
it into VMSTATE_PCIE_DEVICE(). XHCI has VMSTATE_MSIX() in its place,
also operating on PCIDevice.
Is there a way to detect use of AER or MSIX to place those into
subsections of VMSTATE_PCIE_DEVICE()?
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2013-07-23 10:21 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-21 14:09 [Qemu-devel] [PATCH RFC qom-next 0/4] QOM'ification of pci-bridge types Andreas Färber
2013-07-21 14:09 ` [Qemu-devel] [PATCH RFC qom-next 1/4] pci-bridge: Turn into abstract QOM type Andreas Färber
2013-07-21 14:09 ` [Qemu-devel] [PATCH RFC qom-next 2/4] pci-bridge-dev: QOM parent field cleanup Andreas Färber
2013-07-21 14:09 ` [Qemu-devel] [PATCH RFC qom-next 3/4] pci-bridge/i82801b11: Rename parent field Andreas Färber
2013-07-21 14:09 ` [Qemu-devel] [PATCH RFC qom-next 4/4] pcie_port: Turn PCIEPort and PCIESlot into abstract QOM types Andreas Färber
2013-07-21 20:26 ` Michael S. Tsirkin
2013-07-22 17:42 ` Andreas Färber
2013-07-22 19:34 ` Michael S. Tsirkin
2013-07-22 20:29 ` Anthony Liguori
2013-07-22 21:04 ` Andreas Färber
2013-07-23 7:07 ` Michael S. Tsirkin
2013-07-23 9:10 ` Andreas Färber
2013-07-23 9:59 ` Michael S. Tsirkin
2013-07-23 10:21 ` Andreas Färber [this message]
2013-07-23 11:21 ` Gerd Hoffmann
2013-07-23 12:35 ` Michael S. Tsirkin
2013-07-23 7:04 ` Michael S. Tsirkin
2013-07-28 12:36 ` Andreas Färber
2013-07-28 12:58 ` Michael S. Tsirkin
2013-07-21 20:26 ` [Qemu-devel] [PATCH RFC qom-next 0/4] QOM'ification of pci-bridge types Michael S. Tsirkin
2013-07-22 17:22 ` Andreas Färber
2013-07-22 22:05 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51EE593F.4090101@suse.de \
--to=afaerber@suse.de \
--cc=anthony@codemonkey.ws \
--cc=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).