From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50994) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1aef-00022p-7k for qemu-devel@nongnu.org; Tue, 23 Jul 2013 07:21:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V1aed-0004V2-PL for qemu-devel@nongnu.org; Tue, 23 Jul 2013 07:21:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54979) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1aed-0004Uw-HX for qemu-devel@nongnu.org; Tue, 23 Jul 2013 07:21:19 -0400 Message-ID: <51EE6729.1010403@redhat.com> Date: Tue, 23 Jul 2013 13:21:13 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1374415744-6675-1-git-send-email-afaerber@suse.de> <1374415744-6675-5-git-send-email-afaerber@suse.de> <20130721202607.GA15187@redhat.com> <87y58y49tx.fsf@codemonkey.ws> <51ED9E71.3060809@suse.de> <20130723070755.GB11106@redhat.com> <51EE4895.4010207@suse.de> <20130723095954.GA23217@redhat.com> <51EE593F.4090101@suse.de> In-Reply-To: <51EE593F.4090101@suse.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH RFC qom-next 4/4] pcie_port: Turn PCIEPort and PCIESlot into abstract QOM types List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?Andreas_F=E4rber?= Cc: Juan Quintela , qemu-devel@nongnu.org, Anthony Liguori , "Michael S. Tsirkin" Hi, > Okay, so if it's just PCIe, then XHCI is the oddball preventing moving > it into VMSTATE_PCIE_DEVICE(). XHCI has VMSTATE_MSIX() in its place, > also operating on PCIDevice. Given that live migration support for xhci was added post-1.5 so we don't have a release with it yet this shouldn't be a blocker in case we get this sorted in time for 1.6. > Is there a way to detect use of AER or MSIX to place those into > subsections of VMSTATE_PCIE_DEVICE()? There is msix_enabled() ... Dunno about AER. cheers, Gerd