From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35801)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1V1txY-0008Sp-8u
	for qemu-devel@nongnu.org; Wed, 24 Jul 2013 03:58:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1V1txW-0000W8-J2
	for qemu-devel@nongnu.org; Wed, 24 Jul 2013 03:58:08 -0400
Received: from mx1.redhat.com ([209.132.183.28]:8315)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1V1txW-0000Vr-BA
	for qemu-devel@nongnu.org; Wed, 24 Jul 2013 03:58:06 -0400
Message-ID: <51EF88FD.4040603@redhat.com>
Date: Wed, 24 Jul 2013 09:57:49 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <5D9ACBBCF6B270468D615C4719A59BE363DFE97F@szxeml548-mbx.china.huawei.com>
	<51EE2409.7030501@redhat.com>
	<5D9ACBBCF6B270468D615C4719A59BE363DFF990@szxeml548-mbx.china.huawei.com>
	<51EF7814.9050304@redhat.com>
	<5D9ACBBCF6B270468D615C4719A59BE363DFFACD@szxeml548-mbx.china.huawei.com>
In-Reply-To: <5D9ACBBCF6B270468D615C4719A59BE363DFFACD@szxeml548-mbx.china.huawei.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] trim in windows guest witch virtio
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Libaiqing <libaiqing@huawei.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

Il 24/07/2013 09:52, Libaiqing ha scritto:
> Hi paolo,
>      With -M pc,trim works well in windows guest with ide device and ahci bus.
> 
>      About the filter driver,you mean do something in windows virtio-scsi driver,let it send unmap command to qemu?

Yes, it must trap the IOCTL_STORAGE_MANAGE_DATA_SET_ATTRIBUTES ioctl and
convert it to a SCSI UNMAP command.  But your link may suggest that it's
only needed on Windows < 8 (and Server < 2012).

Paolo

> Thanks
> baiqing.