From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44597)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V1uLL-0000fJ-Mi
	for qemu-devel@nongnu.org; Wed, 24 Jul 2013 04:22:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V1uLK-0000qV-Nl
	for qemu-devel@nongnu.org; Wed, 24 Jul 2013 04:22:43 -0400
Message-ID: <51EF8ECA.4070807@suse.de>
Date: Wed, 24 Jul 2013 10:22:34 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1374175984-8930-1-git-send-email-aliguori@us.ibm.com>
	<1374175984-8930-2-git-send-email-aliguori@us.ibm.com>
	<51EF8D74.1000607@ozlabs.ru>
In-Reply-To: <51EF8D74.1000607@ozlabs.ru>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2 01/11] target-ppc: Convert ppc cpu
 savevm to VMStateDescription
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexey Kardashevskiy <aik@ozlabs.ru>, Anthony Liguori <aliguori@us.ibm.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-ppc@nongnu.org, qemu-devel@nongnu.org, David Gibson <david@gibson.dropbear.id.au>

Am 24.07.2013 10:16, schrieb Alexey Kardashevskiy:
> On 07/19/2013 05:32 AM, Anthony Liguori wrote:
>> diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
>> index 79bfcd8..09ea944 100644
>> --- a/target-ppc/translate_init.c
>> +++ b/target-ppc/translate_init.c
>> @@ -8449,6 +8449,8 @@ static void ppc_cpu_class_init(ObjectClass *oc, =
void *data)
>>      cc->do_interrupt =3D ppc_cpu_do_interrupt;
>>      cc->dump_state =3D ppc_cpu_dump_state;
>>      cc->dump_statistics =3D ppc_cpu_dump_statistics;
>> +
>> +    cpu_class_set_vmsd(cc, &vmstate_ppc_cpu);
>>  }
>=20
>=20
> Does not apply on the current master from qemu.org, need this:
>=20
> diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
> index f97c0c7..f377b74 100644
> --- a/target-ppc/translate_init.c
> +++ b/target-ppc/translate_init.c
> @@ -8462,7 +8462,7 @@ static void ppc_cpu_class_init(ObjectClass *oc, v=
oid
> *data)
>      cc->get_phys_page_debug =3D ppc_cpu_get_phys_page_debug;
>  #endif
>=20
> -    cpu_class_set_vmsd(cc, &vmstate_ppc_cpu);
> +    dc->vmsd =3D &vmstate_ppc_cpu;
>  }
>=20
>  static const TypeInfo ppc_cpu_type_info =3D {

That would break ppc-linux-user. It needs to go into the #ifdef above,
which obsoleted cpu_class_set_vmsd().

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg