From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55871) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1v08-0004z0-Hu for qemu-devel@nongnu.org; Wed, 24 Jul 2013 05:04:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V1v07-0007oR-8p for qemu-devel@nongnu.org; Wed, 24 Jul 2013 05:04:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:13757) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1v07-0007mk-0w for qemu-devel@nongnu.org; Wed, 24 Jul 2013 05:04:51 -0400 Message-ID: <51EF988E.8000409@redhat.com> Date: Wed, 24 Jul 2013 11:04:14 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1374596592-7027-1-git-send-email-imammedo@redhat.com> <1374596592-7027-4-git-send-email-imammedo@redhat.com> <51EEB943.7080306@redhat.com> <20130724104058.7d08adca@nial.usersys.redhat.com> In-Reply-To: <20130724104058.7d08adca@nial.usersys.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 03/16] vl: convert -m to qemu_opts_parse() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: vasilis.liaskovitis@profitbricks.com, hutao@cn.fujitsu.com, qemu-devel@nongnu.org Il 24/07/2013 10:40, Igor Mammedov ha scritto: > On Tue, 23 Jul 2013 19:11:31 +0200 > Paolo Bonzini wrote: > >> Il 23/07/2013 18:22, Igor Mammedov ha scritto: >>> Signed-off-by: Igor Mammedov >>> --- >>> qemu-options.hx | 9 +++++++-- >>> vl.c | 53 +++++++++++++++++++++++++++++++++++++++++++++++------ >>> 2 files changed, 54 insertions(+), 8 deletions(-) >>> >>> diff --git a/qemu-options.hx b/qemu-options.hx >>> index 137a39b..f799b3d 100644 >>> --- a/qemu-options.hx >>> +++ b/qemu-options.hx >>> @@ -210,8 +210,13 @@ use is discouraged as it may be removed from future versions. >>> ETEXI >>> >>> DEF("m", HAS_ARG, QEMU_OPTION_m, >>> - "-m megs set virtual RAM size to megs MB [default=" >>> - stringify(DEFAULT_RAM_SIZE) "]\n", QEMU_ARCH_ALL) >>> + "-m [mem=]megs[,slots=n,maxmem=size]\n" >>> + " set virtual RAM size to megs MB [default=" >>> + stringify(DEFAULT_RAM_SIZE) "]\n" >>> + " mem=start-up memory amount\n" >>> + " slots=maximum number of hotplug slots\n" >>> + " maxmem=maximum total amount of memory\n", >>> + QEMU_ARCH_ALL) >>> STEXI >>> @item -m @var{megs} >>> @findex -m >>> diff --git a/vl.c b/vl.c >>> index bf0c658..16c6f1e 100644 >>> --- a/vl.c >>> +++ b/vl.c >>> @@ -516,6 +516,27 @@ static QemuOptsList qemu_realtime_opts = { >>> }, >>> }; >>> >>> +static QemuOptsList qemu_mem_opts = { >>> + .name = "memory-opts", >>> + .implied_opt_name = "mem", >>> + .head = QTAILQ_HEAD_INITIALIZER(qemu_mem_opts.head), >> >> This should have >> >> .merge_lists = true, > > Just to clarify: is it to allow syntax like? > -m 512 -m slots=X -m maxmem=Y Yes. In general, if "id" doesn't make sense the QemuOptsList should have merge_lists=true. Paolo