From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54166)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1V1yxW-00039o-8y
	for qemu-devel@nongnu.org; Wed, 24 Jul 2013 09:18:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1V1yxT-0002ok-Ub
	for qemu-devel@nongnu.org; Wed, 24 Jul 2013 09:18:26 -0400
Received: from mx1.redhat.com ([209.132.183.28]:38744)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1V1yxT-0002oR-LY
	for qemu-devel@nongnu.org; Wed, 24 Jul 2013 09:18:23 -0400
Message-ID: <51EFD409.8030601@redhat.com>
Date: Wed, 24 Jul 2013 15:18:01 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <20130724060104.GA18072@redhat.com> <51EF7BDF.2070503@redhat.com>
	<20130724095116.GB26778@redhat.com> <51EFCFA6.2050506@redhat.com>
	<20130724131411.GB29428@redhat.com>
In-Reply-To: <20130724131411.GB29428@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] pc: limit 64 bit hole to 2G by default
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org, Isaku Yamahata <yamahata@valinux.co.jp>, Alex Williamson <alex.williamson@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>, Laszlo Ersek <lersek@redhat.com>, =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>, David Gibson <david@gibson.dropbear.id.au>

Il 24/07/2013 15:14, Michael S. Tsirkin ha scritto:
> On Wed, Jul 24, 2013 at 02:59:18PM +0200, Paolo Bonzini wrote:
>> Il 24/07/2013 11:51, Michael S. Tsirkin ha scritto:
>>>> Current seabios uses a slightly different approach: the 64bit hole is
>>>> present only in case it is actually used to map bars there, and seabios
>>>> tries to fit everything into the 32bit hole first.
>>>
>>> Yes. But this doesn't work with device hotplug.
>>
>> Are you preserving that behavior for older machine types?
> 
> Older machine types (1.5 and back) don't report PCI hole size to guests
> so there's nothing to preserve.

So pc-1.5 and older always use the SeaBIOS ACPI tables, even on new
QEMU?  (I guess I should review your ACPI table patches).

Paolo

> This means there's not much I can do for pc-1.5: as before this
> patch, hotplug of devices with large BARs won't work,
> and some windows guests will crash if a device with a huge
> BAR is added statically.
> 
>> (Also, what happens if you do -global i440FX-pcihost.pci_hole64_size=0?
>>  Does that return a _CRS with only the 32-bit hole)?
>>
>> Paolo
> 
> Yes.
>