From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53834) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V20c6-0002nT-St for qemu-devel@nongnu.org; Wed, 24 Jul 2013 11:04:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V20c5-00072Y-JN for qemu-devel@nongnu.org; Wed, 24 Jul 2013 11:04:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:4584) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V20c5-00072Q-Ba for qemu-devel@nongnu.org; Wed, 24 Jul 2013 11:04:25 -0400 Message-ID: <51EFECE9.3090308@redhat.com> Date: Wed, 24 Jul 2013 17:04:09 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1373307914-18543-1-git-send-email-mst@redhat.com> <1373307914-18543-4-git-send-email-mst@redhat.com> <87fvvo3m2c.fsf@codemonkey.ws> <20130708195259.GA19775@redhat.com> <51EFE7C0.5060202@redhat.com> <51EFEA15.1090700@suse.de> In-Reply-To: <51EFEA15.1090700@suse.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [SeaBIOS] [PATCH v2 3/4] i386: generate pc guest info List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?Andreas_F=E4rber?= Cc: Anthony Liguori , seabios@seabios.org, qemu-devel@nongnu.org, Aurelien Jarno , "Michael S. Tsirkin" Hi, >> /me suggests to check out qmp_qom_get() in qmp.c. Some qom aequivalent >> for qdev_find_recursive would be handy, dunno whenever such a thing >> exists already, Andreas? > > Not sure what's needed here? object_resolve_path() and > object_foreach_child() come to mind... object_resolve_path should do to (a) figure whenever we are i440fx or q35 and (b) get the pcihost device (then read enable_s3 etc properties). For pvpanic (and maybe others) it might be handy to have "find me the device of type TYPE_ISA_PVPANIC_DEVICE, anywhere in the tree" functionality, so the same code works no matter where the isa bridge happens to live. Or "find me all pci bridges in the system". Is object_foreach_child recursive? Then it might do the job ... cheers, Gerd