From: Paolo Bonzini <pbonzini@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
seabios@seabios.org, qemu-devel@nongnu.org,
Gerd Hoffmann <kraxel@redhat.com>,
Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [SeaBIOS] [PATCH v2 3/4] i386: generate pc guest info
Date: Wed, 24 Jul 2013 17:11:36 +0200 [thread overview]
Message-ID: <51EFEEA8.3030309@redhat.com> (raw)
In-Reply-To: <51EFEE0F.1090605@suse.de>
Il 24/07/2013 17:09, Andreas Färber ha scritto:
> Hi,
>
> Am 24.07.2013 17:04, schrieb Gerd Hoffmann:
>>>> /me suggests to check out qmp_qom_get() in qmp.c. Some qom aequivalent
>>>> for qdev_find_recursive would be handy, dunno whenever such a thing
>>>> exists already, Andreas?
>>>
>>> Not sure what's needed here? object_resolve_path() and
>>> object_foreach_child() come to mind...
>>
>> object_resolve_path should do to (a) figure whenever we are i440fx or
>> q35 and (b) get the pcihost device (then read enable_s3 etc properties).
>>
>> For pvpanic (and maybe others) it might be handy to have "find me the
>> device of type TYPE_ISA_PVPANIC_DEVICE, anywhere in the tree"
>> functionality, so the same code works no matter where the isa bridge
>> happens to live. Or "find me all pci bridges in the system".
>
> I think Paolo used object_resolve_path_type("", TYPE_...) for that
> somewhere in audio code.
Yes. It returns NULL if there is more than one device, but in some
cases it may be exactly what you want...
Paolo
>> Is object_foreach_child recursive? Then it might do the job ...
>
> No, recursion would need to be implemented in the callback - my recent
> recursive QOM realization series had an example of a deep search for
> devices.
>
> Regards,
> Andreas
>
next prev parent reply other threads:[~2013-07-24 15:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-08 18:30 [Qemu-devel] [PATCH v2 0/4] qemu: generate acpi tables for the guest Michael S. Tsirkin
2013-07-08 18:30 ` [Qemu-devel] [PATCH v2 1/4] loader: support for unmapped ROM blobs Michael S. Tsirkin
2013-07-08 18:30 ` [Qemu-devel] [PATCH v2 2/4] loader: allow adding ROMs in done callbacks Michael S. Tsirkin
2013-07-08 18:30 ` [Qemu-devel] [PATCH v2 3/4] i386: generate pc guest info Michael S. Tsirkin
2013-07-08 19:10 ` [Qemu-devel] [SeaBIOS] " Anthony Liguori
2013-07-08 19:52 ` Michael S. Tsirkin
2013-07-24 14:42 ` Gerd Hoffmann
2013-07-24 14:52 ` Andreas Färber
2013-07-24 15:04 ` Gerd Hoffmann
2013-07-24 15:09 ` Andreas Färber
2013-07-24 15:11 ` Paolo Bonzini [this message]
2013-07-24 16:17 ` Michael S. Tsirkin
2013-07-24 15:28 ` Michael S. Tsirkin
2013-07-11 20:25 ` [Qemu-devel] " Michael S. Tsirkin
2013-07-08 18:30 ` [Qemu-devel] [PATCH v2 4/4] i386: ACPI table generation code from seabios Michael S. Tsirkin
2013-07-08 19:16 ` [Qemu-devel] [SeaBIOS] " Anthony Liguori
2013-07-08 19:57 ` Michael S. Tsirkin
2013-07-09 7:53 ` [Qemu-devel] [PATCH v2 0/4] qemu: generate acpi tables for the guest Laszlo Ersek
2013-07-09 7:57 ` Michael S. Tsirkin
2013-07-09 8:04 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51EFEEA8.3030309@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=aurelien@aurel32.net \
--cc=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=seabios@seabios.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).