qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eduardo Otubo <otubo@linux.vnet.ibm.com>
To: Paul Moore <pmoore@redhat.com>
Cc: coreyb@linux.vnet.ibm.com, qemu-devel@nongnu.org, qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] seccomp: add arch_prctl() to the syscall whitelist
Date: Wed, 24 Jul 2013 15:01:57 -0300	[thread overview]
Message-ID: <51F01695.6070801@linux.vnet.ibm.com> (raw)
In-Reply-To: <7859073.tKPvLxPtrm@sifl>



On 07/23/2013 10:57 AM, Paul Moore wrote:
> On Thursday, July 18, 2013 09:57:03 AM Paul Moore wrote:
>> It appears that even a very simple /etc/qemu-ifup configuration can
>> require the arch_prctl() syscall, see the example below:
>>
>> 	#!/bin/sh
>> 	/sbin/ifconfig $1 0.0.0.0 up
>> 	/usr/sbin/brctl addif <switch> $1
>>
>> Signed-off-by: Paul Moore <pmoore@redhat.com>
>
> As with the other fix, a gentle nudge so this isn't forgotten.

Reviewed and tested.

Reviewed-by: Eduardo Otubo <otubo@linux.vnet.ibm.com>

>
>> ---
>>   qemu-seccomp.c |    3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/qemu-seccomp.c b/qemu-seccomp.c
>> index 173d185..9e91c73 100644
>> --- a/qemu-seccomp.c
>> +++ b/qemu-seccomp.c
>> @@ -234,7 +234,8 @@ static const struct QemuSeccompSyscall
>> seccomp_whitelist[] = { { SCMP_SYS(waitid), 241 },
>>       { SCMP_SYS(io_cancel), 241 },
>>       { SCMP_SYS(io_setup), 241 },
>> -    { SCMP_SYS(io_destroy), 241 }
>> +    { SCMP_SYS(io_destroy), 241 },
>> +    { SCMP_SYS(arch_prctl), 240 }
>>   };
>>
>>   int seccomp_start(void)

-- 
Eduardo Otubo
IBM Linux Technology Center

  reply	other threads:[~2013-07-24 18:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-18 13:57 [Qemu-devel] [PATCH] seccomp: add arch_prctl() to the syscall whitelist Paul Moore
2013-07-23 13:57 ` Paul Moore
2013-07-24 18:01   ` Eduardo Otubo [this message]
2013-07-29 22:12     ` Paul Moore
2013-08-02 12:35 ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51F01695.6070801@linux.vnet.ibm.com \
    --to=otubo@linux.vnet.ibm.com \
    --cc=coreyb@linux.vnet.ibm.com \
    --cc=pmoore@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).