From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39896)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1V2JMC-0007gE-L1
	for qemu-devel@nongnu.org; Thu, 25 Jul 2013 07:05:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1V2JMB-0004fU-3U
	for qemu-devel@nongnu.org; Thu, 25 Jul 2013 07:05:16 -0400
Received: from mx1.redhat.com ([209.132.183.28]:65248)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1V2JMA-0004fO-Rh
	for qemu-devel@nongnu.org; Thu, 25 Jul 2013 07:05:15 -0400
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6PB5ER1002557
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 25 Jul 2013 07:05:14 -0400
Message-ID: <51F10668.5020100@redhat.com>
Date: Thu, 25 Jul 2013 13:05:12 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1374681580-17439-1-git-send-email-mst@redhat.com>
	<1374681580-17439-13-git-send-email-mst@redhat.com>
	<51F0FE20.7050302@redhat.com> <20130725105526.GA28819@redhat.com>
In-Reply-To: <20130725105526.GA28819@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 12/14] pvpanic: add API to access io port
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org

  Hi,

> I can change the implementation but I don't think it's
> a good idea to copy property names around:
> it's too fragile, compiler won't warn us if we
> change the name or value semantics,

I'm not worried.  Changing the strings will break the command line
interface too (qemu -device pvpanic,ioport=...), so that isn't going to
happen.

cheers,
  Gerd