From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56674)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1V2KRU-0000z2-UF
	for qemu-devel@nongnu.org; Thu, 25 Jul 2013 08:14:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1V2KRQ-0003Jo-AI
	for qemu-devel@nongnu.org; Thu, 25 Jul 2013 08:14:48 -0400
Received: from mx1.redhat.com ([209.132.183.28]:59122)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1V2KRQ-0003Jj-27
	for qemu-devel@nongnu.org; Thu, 25 Jul 2013 08:14:44 -0400
Message-ID: <51F116B0.5030506@redhat.com>
Date: Thu, 25 Jul 2013 14:14:40 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1374681580-17439-1-git-send-email-mst@redhat.com>
	<1374681580-17439-8-git-send-email-mst@redhat.com>
In-Reply-To: <1374681580-17439-8-git-send-email-mst@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 07/14] loader: support for unmapped ROM
 blobs
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Michael Walle <michael@walle.cc>, qemu-devel@nongnu.org

On 07/24/13 18:01, Michael S. Tsirkin wrote:
>      QTAILQ_FOREACH(rom, &roms, next) {
> +        if (rom->mr) {
> +            continue;
> +        }
>          if (rom->fw_file) {
>              continue;
>          }
>          if (rom->data == NULL) {
>              continue;
>          }
> -        cpu_physical_memory_write_rom(rom->addr, rom->data, rom->datasize);
> +        if (rom->mr) {
> +            void *host = memory_region_get_ram_ptr(rom->mr);
> +            memcpy(host, rom->data, rom->datasize);

I think this code never ever runs ...

cheers,
  Gerd