From: Paolo Bonzini <pbonzini@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: pl@kamp.de, famz@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 14/17] raw-posix: return get_block_status data and flags
Date: Thu, 25 Jul 2013 14:16:22 +0200 [thread overview]
Message-ID: <51F11716.1080309@redhat.com> (raw)
In-Reply-To: <51E99819.9040803@redhat.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Il 19/07/2013 21:48, Eric Blake ha scritto:
>>> start = sector_num * BDRV_SECTOR_SIZE; + ret =
>>> BDRV_BLOCK_DATA | BDRV_BLOCK_OFFSET_VALID | start;
> off_t is a signed type; if you are compiling on a platform with
> 32-bit off_t, is it possible that you will get unintended sign
> extension for values of 'start' between 2 and 4 GB? Or are such
> files already impossible to open? [Or do we intentionally require
> off_t be 64-bits on all platforms we care about?]
Good question. If we don't, we should.
In the meanwhile, I'll change start/data/hole to be int64_t.
Paolo
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBAgAGBQJR8RcVAAoJEBvWZb6bTYbymN0P/15/doObltN+2vCE1WtQD8IZ
Woqd/Itct/1KXHCLv423ThO23/WpE3KSPna25a19sGeJQSXdZB7E2shDtxNErEob
a0c0n6yMzDI0iU+UX1/mPacoIZt5tiWHzd3W4sTIgVDjHUa1Xctgp8bv3gNFNHzh
Ese6mdNNhJQCPqA67qLhzSGfnWUCxGV0F9HDK23dfYJUQ8yoEnRWqLYjRH0qgEG4
LRydUCyfU3BjvmRlLLRMrJHxSJKQKbYMO94IY1ZPqKn1TxKPnOHdIYOgNP8wFAWA
3uA5kc0r9qEmSyh01dbQ+bBkp9lRzDRgxrmii4LZXiQvF6kAXxrY5fEuUHrewGwC
1KeFccGLkgWH1jI19M8URjzbjQwGm79yYIqlt4ZLDwam88VXlxYse7odaRESGSWY
HQqak7WSlDFPlvNj7eR3lruGN3E9F6XAoMCVwRnPRbrx9G9ezH302VF7IXHvlFJu
yK+iRwoWUSkKPWVBxiMrI5HAWlt4N6Akje2VPhkaJQYBQ0LwLhMiDWfMJySW9M7I
qNz/CjbMljwEGOEjYZ7PUKd0H76mcX1xwDi3ofBkJn3Bu74+C5xs7ZRRNO/tIu2c
mVxxYbP7R3dTDdF6sOTVIjUt9M7ObDJ0I0Y0aev1BSTv5tiZb9KB+ef9DRn2Drhk
cVcuJYJiEvL3JV9J5zDE
=ANdZ
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2013-07-25 12:16 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-16 16:29 [Qemu-devel] [PATCH v2 00/17] Add qemu-img subcommand to dump file metadata Paolo Bonzini
2013-07-16 16:29 ` [Qemu-devel] [PATCH v2 01/17] cow: make reads go at a decent speed Paolo Bonzini
2013-07-19 12:31 ` Eric Blake
2013-07-16 16:29 ` [Qemu-devel] [PATCH v2 02/17] cow: make writes go at a less indecent speed Paolo Bonzini
2013-07-19 12:40 ` Eric Blake
2013-07-16 16:29 ` [Qemu-devel] [PATCH v2 03/17] cow: do not call bdrv_co_is_allocated Paolo Bonzini
2013-07-19 12:42 ` Eric Blake
2013-07-16 16:29 ` [Qemu-devel] [PATCH v2 04/17] block: make bdrv_co_is_allocated static Paolo Bonzini
2013-07-19 12:44 ` Eric Blake
2013-07-16 16:29 ` [Qemu-devel] [PATCH v2 05/17] block: remove bdrv_is_allocated_above/bdrv_co_is_allocated_above distinction Paolo Bonzini
2013-07-19 12:46 ` Eric Blake
2013-07-16 16:29 ` [Qemu-devel] [PATCH v2 06/17] block: expect errors from bdrv_co_is_allocated Paolo Bonzini
2013-07-19 12:57 ` Eric Blake
2013-07-16 16:29 ` [Qemu-devel] [PATCH v2 07/17] qemu-img: always probe the input image for allocated sectors Paolo Bonzini
2013-07-19 13:05 ` Eric Blake
2013-07-16 16:29 ` [Qemu-devel] [PATCH v2 08/17] block: make bdrv_has_zero_init return false for copy-on-write-images Paolo Bonzini
2013-07-19 13:21 ` Eric Blake
2013-07-19 13:23 ` Paolo Bonzini
2013-07-16 16:29 ` [Qemu-devel] [PATCH v2 09/17] block: introduce bdrv_get_block_status API Paolo Bonzini
2013-07-19 13:43 ` Eric Blake
2013-07-25 12:13 ` Paolo Bonzini
2013-07-16 16:29 ` [Qemu-devel] [PATCH v2 10/17] block: define get_block_status return value Paolo Bonzini
2013-07-19 6:35 ` Peter Lieven
2013-07-19 9:14 ` Paolo Bonzini
2013-07-19 6:48 ` Peter Lieven
2013-07-19 9:12 ` Paolo Bonzini
2013-07-19 9:58 ` Paolo Bonzini
2013-07-19 10:04 ` Peter Lieven
2013-07-19 12:13 ` Paolo Bonzini
2013-07-19 13:06 ` Peter Lieven
2013-07-20 7:00 ` Paolo Bonzini
2013-07-23 21:18 ` Peter Lieven
2013-07-19 16:52 ` Eric Blake
2013-07-16 16:29 ` [Qemu-devel] [PATCH v2 11/17] block: return get_block_status data and flags for formats Paolo Bonzini
2013-07-19 19:25 ` Eric Blake
2013-07-16 16:29 ` [Qemu-devel] [PATCH v2 12/17] qemu-img: add a "map" subcommand Paolo Bonzini
2013-07-18 7:25 ` Fam Zheng
2013-07-18 8:55 ` Paolo Bonzini
2013-07-19 19:36 ` Eric Blake
2013-07-16 16:29 ` [Qemu-devel] [PATCH v2 13/17] block: use bdrv_has_zero_init to return BDRV_BLOCK_ZERO Paolo Bonzini
2013-07-17 17:50 ` Peter Lieven
2013-07-19 19:37 ` Eric Blake
2013-07-16 16:29 ` [Qemu-devel] [PATCH v2 14/17] raw-posix: return get_block_status data and flags Paolo Bonzini
2013-07-19 19:48 ` Eric Blake
2013-07-25 12:16 ` Paolo Bonzini [this message]
2013-07-16 16:29 ` [Qemu-devel] [PATCH v2 15/17] raw-posix: detect XFS unwritten extents Paolo Bonzini
2013-07-19 20:10 ` Eric Blake
2013-08-02 15:05 ` Christoph Hellwig
2013-07-16 16:29 ` [Qemu-devel] [PATCH v2 16/17] block: add default get_block_status implementation for protocols Paolo Bonzini
2013-07-19 20:11 ` Eric Blake
2013-07-16 16:29 ` [Qemu-devel] [PATCH v2 17/17] block: look for zero blocks in bs->file Paolo Bonzini
2013-07-19 7:33 ` Stefan Hajnoczi
2013-07-19 17:07 ` Paolo Bonzini
2013-07-23 21:18 ` Peter Lieven
2013-07-19 20:12 ` Eric Blake
2013-07-16 16:56 ` [Qemu-devel] [PATCH v2 00/17] Add qemu-img subcommand to dump file metadata Eric Blake
2013-07-16 16:57 ` Paolo Bonzini
2013-07-19 10:48 ` Wenchao Xia
2013-07-19 12:14 ` Paolo Bonzini
2013-07-20 0:19 ` Wenchao Xia
2013-07-18 8:17 ` Peter Lieven
2013-07-18 8:58 ` Paolo Bonzini
2013-07-19 4:45 ` Stefan Hajnoczi
2013-07-19 7:34 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F11716.1080309@redhat.com \
--to=pbonzini@redhat.com \
--cc=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).