From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33546) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2KjL-0000mM-V7 for qemu-devel@nongnu.org; Thu, 25 Jul 2013 08:33:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V2KjG-0001f9-1j for qemu-devel@nongnu.org; Thu, 25 Jul 2013 08:33:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8752) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2KjF-0001es-RR for qemu-devel@nongnu.org; Thu, 25 Jul 2013 08:33:09 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6PCX9ut027481 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 25 Jul 2013 08:33:09 -0400 Message-ID: <51F11B02.9010202@redhat.com> Date: Thu, 25 Jul 2013 14:33:06 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1374681580-17439-1-git-send-email-mst@redhat.com> <1374681580-17439-11-git-send-email-mst@redhat.com> In-Reply-To: <1374681580-17439-11-git-send-email-mst@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 10/14] ich9: APIs for pc guest info List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org On 07/24/13 18:02, Michael S. Tsirkin wrote: > This adds APIs that will be used to fill in > guest info table, implemented using QOM, > to various ich9 components. Uses QOM to lookup the device state without needing nasty hooks in machine creation. Then goes copy info directly from device state as the bits needed are not exported as properties. Looks reasonable to me. Reviewed-by: Gerd Hoffmann cheers, Gerd