From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44540)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1V2LFt-0003FL-B5
	for qemu-devel@nongnu.org; Thu, 25 Jul 2013 09:06:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1V2LFs-0005mG-30
	for qemu-devel@nongnu.org; Thu, 25 Jul 2013 09:06:53 -0400
Received: from david.siemens.de ([192.35.17.14]:29118)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1V2LFr-0005lb-Pk
	for qemu-devel@nongnu.org; Thu, 25 Jul 2013 09:06:52 -0400
Message-ID: <51F122DE.2010801@siemens.com>
Date: Thu, 25 Jul 2013 15:06:38 +0200
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <1374396185-10870-1-git-send-email-pingfank@linux.vnet.ibm.com>
	<20130725120530.GJ21033@stefanha-thinkpad.redhat.com>
	<C471CD9FB0C93A3C362BD247@nimrod.local>
	<51F11AFB.9040008@siemens.com> <51F11B94.8090400@redhat.com>
	<51F11C63.40007@siemens.com>
	<CAJSP0QXbeDqdKYTW-5CKZR7MNTSTNLnbqO-n2j6o+OsT9=SaFg@mail.gmail.com>
	<51F11EA8.9050108@siemens.com> <51F121E1.4060805@redhat.com>
In-Reply-To: <51F121E1.4060805@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC 0/8] arm AioContext with its own timer stuff
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Alex Bligh <alex@alex.org.uk>, Stefan Hajnoczi <stefanha@gmail.com>, Liu Ping Fan <qemulist@gmail.com>, qemu-devel <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>, Anthony Liguori <anthony@codemonkey.ws>

On 2013-07-25 15:02, Paolo Bonzini wrote:
> Il 25/07/2013 14:48, Jan Kiszka ha scritto:
>> The concept of clocks (with start/stop property) and active timers shall
>> not be mixed, they are independent. 
> 
> Are you referring to this in particular:
> 
> void pause_all_vcpus(void)
> {
>     CPUState *cpu = first_cpu;
> 
>     qemu_clock_enable(vm_clock, false);
> ...
> }
> 
> void resume_all_vcpus(void)
> {
>     CPUState *cpu = first_cpu;
> 
>     qemu_clock_enable(vm_clock, true);
> ...
> }
> 
> where _all_ the vm_clock timer lists need to be stopped at the same time?

Still wrong abstraction: the vm_clock is stopped. And that implies that
no timer using this clock will fire anymore.

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux