From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43751) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2MsO-00025e-TT for qemu-devel@nongnu.org; Thu, 25 Jul 2013 10:50:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V2MsN-0000ts-G8 for qemu-devel@nongnu.org; Thu, 25 Jul 2013 10:50:44 -0400 Received: from cantor2.suse.de ([195.135.220.15]:49440 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2MsN-0000tl-Ab for qemu-devel@nongnu.org; Thu, 25 Jul 2013 10:50:43 -0400 Message-ID: <51F13B3E.4080707@suse.de> Date: Thu, 25 Jul 2013 16:50:38 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1374676642-2412-1-git-send-email-pbonzini@redhat.com> <51EFEC3B.7060805@suse.de> <20130725101412.GD22735@redhat.com> <51F13A46.7010003@suse.de> In-Reply-To: <51F13A46.7010003@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] kvm: migrate vPMU state List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gleb Natapov , Paolo Bonzini Cc: qemu-devel@nongnu.org, ehabkost@redhat.com Am 25.07.2013 16:46, schrieb Andreas F=C3=A4rber: > Am 25.07.2013 12:14, schrieb Gleb Natapov: >> On Wed, Jul 24, 2013 at 05:01:15PM +0200, Andreas F=C3=A4rber wrote: >>> New msr_* fields would be candidates for X86CPU, but there's already = one >>> in CPUX86State. :/ >>> >> Is this NAK? >=20 > No, it was more an implicit question of whether Paolo had considered a > different placement? >=20 > Since there is a uint64_t msr_ia32_misc_enable visible as precedent, I > was thinking it would be better for consistency to do such movements as > follow-up, if at all. However checking on that now, I do not have any > msr_* there in my repo, and it is after CPU_COMMON, thus not reset - > Paolo, what do you think? Consider me confused, please ignore. msr_ia32_misc_enable is further above and is *before* CPU_COMMON, thus moving it into X86CPU would require zero'ing them on reset, so not as simple as a pure code movement and s/env/cpu/g, so better leave it as is for now so short before v1.6 Hard Freeze. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg