From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36977) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2NuV-0005j0-Go for qemu-devel@nongnu.org; Thu, 25 Jul 2013 11:57:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V2NuT-0000x4-0x for qemu-devel@nongnu.org; Thu, 25 Jul 2013 11:56:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34497) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2NuS-0000wm-Nn for qemu-devel@nongnu.org; Thu, 25 Jul 2013 11:56:56 -0400 Message-ID: <51F14AAE.5060602@redhat.com> Date: Thu, 25 Jul 2013 09:56:30 -0600 From: Eric Blake MIME-Version: 1.0 References: <1374284656-12025-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1374284656-12025-11-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1374284656-12025-11-git-send-email-xiawenc@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2Q1fx4cL5101DLadMxpp7XFtxJCkCLH65" Subject: Re: [Qemu-devel] [PATCH V7 10/13] monitor: refine monitor_find_completion() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: armbru@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --2Q1fx4cL5101DLadMxpp7XFtxJCkCLH65 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/19/2013 07:44 PM, Wenchao Xia wrote: > In order to support sub command in auto completion, an reentrant functi= on s/an/a/ > is needed, so monitor_find_completion() is splitted into two parts. The= s/splitted/split/ > first part does parsing of user input which need to be done only once, > the second part does the auto completion job according to the parsing > result, which contains the necessary code to support sub command and > works as the reentrant function. The global "info_cmds" is still used > in second part, which will be replaced by sub command code later. >=20 > Signed-off-by: Wenchao Xia > --- > monitor.c | 65 ++++++++++++++++++++++++++++++++++++-----------------= ------- > 1 files changed, 39 insertions(+), 26 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --2Q1fx4cL5101DLadMxpp7XFtxJCkCLH65 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJR8UquAAoJEKeha0olJ0Nqz8EH/jS1XItasySfddoX0D9BqKq4 lZ2+Rjda+ThtumyqX3Eb+EqquO0BUt7DNbO7/AtwP51wbSA817rKYCtrvpglO2H4 jCj5fJgMO0llWXe8D5oPNl/Qs++GfXYpZvhG+GFZE/YhKWnTZM2ra25meTkODFin z4i00zvH8x6Whny666a+yy3iwg5LhXFIiyTPDZE54FeRBy/LhoNqzUOd99XGNBND 0KMdQDpiOmqBmPqMs4mpIJkKor71YuNIV2klmpnNssL7jFN46ybcodVdGShcka+P 47jpqKOq1ZLPL6JthOpXqZ1CIk9xDxPHvxj47up59GLpQLxIb+KDpFh2CQXqywk= =YvDA -----END PGP SIGNATURE----- --2Q1fx4cL5101DLadMxpp7XFtxJCkCLH65--