From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47307)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1V2bz5-0000iq-9w
	for qemu-devel@nongnu.org; Fri, 26 Jul 2013 02:58:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1V2bz1-0001m0-To
	for qemu-devel@nongnu.org; Fri, 26 Jul 2013 02:58:39 -0400
Received: from mail-wg0-x232.google.com ([2a00:1450:400c:c00::232]:40705)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1V2bz1-0001lp-NZ
	for qemu-devel@nongnu.org; Fri, 26 Jul 2013 02:58:35 -0400
Received: by mail-wg0-f50.google.com with SMTP id m15so2485949wgh.5
	for <qemu-devel@nongnu.org>; Thu, 25 Jul 2013 23:58:34 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <51F21E08.8060109@redhat.com>
Date: Fri, 26 Jul 2013 08:58:16 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1374800982-2818-1-git-send-email-imain@redhat.com>
	<1374800982-2818-2-git-send-email-imain@redhat.com>
In-Reply-To: <1374800982-2818-2-git-send-email-imain@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH V7 1/2] Implement sync modes for
	drive-backup.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Ian Main <imain@redhat.com>
Cc: kwolf@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, rjones@redhat.com

Il 26/07/2013 03:09, Ian Main ha scritto:
> +    /* See if we have a backing HD we can use to create our new image
> +     * on top of. */
> +    source = bs->backing_hd;
> +    if (!source && sync == MIRROR_SYNC_MODE_TOP) {
> +        sync = MIRROR_SYNC_MODE_FULL;
> +    }
> +

I understand why you left out the "magic" backing file manipulation, but
source should still be "bs" for MIRROR_SYNC_MODE_NONE.

Paolo