From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59931) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2enP-0003MI-3E for qemu-devel@nongnu.org; Fri, 26 Jul 2013 05:58:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V2enO-0005Wa-3p for qemu-devel@nongnu.org; Fri, 26 Jul 2013 05:58:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10978) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2enN-0005WQ-Sa for qemu-devel@nongnu.org; Fri, 26 Jul 2013 05:58:46 -0400 Message-ID: <51F2484E.4020308@redhat.com> Date: Fri, 26 Jul 2013 11:58:38 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1374829812-5201-1-git-send-email-aik@ozlabs.ru> In-Reply-To: <1374829812-5201-1-git-send-email-aik@ozlabs.ru> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3] hcd-ohci: add dma error handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy Cc: Anthony Liguori , qemu-devel@nongnu.org On 07/26/13 11:10, Alexey Kardashevskiy wrote: > Current hcd-ohci does not handle DMA errors. However they may happen > so here we introduce simple error handling. > > On such errors, a typical OHCI will stop operating, signal the guest > about the error by sending "UnrecoverableError Event", set itself into > error state and set "Detected Parity Error" in its PCI config space > to signal that it got an error and so does the patch. > > This also adds ohci_stop() call to ohci_bus_start() to handle possible > failure of qemu_new_timer_ns(). > > Signed-off-by: Alexey Kardashevskiy Looks sane to me now. When I get an ack from Benjamin I'll go put it into the usb patch queue. cheers, Gerd