From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41804)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1V2fUL-0005kS-LN
	for qemu-devel@nongnu.org; Fri, 26 Jul 2013 06:43:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1V2fUK-0004cj-3i
	for qemu-devel@nongnu.org; Fri, 26 Jul 2013 06:43:09 -0400
Received: from mx1.redhat.com ([209.132.183.28]:45538)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1V2fUJ-0004cW-Sw
	for qemu-devel@nongnu.org; Fri, 26 Jul 2013 06:43:08 -0400
Message-ID: <51F252B7.5060409@redhat.com>
Date: Fri, 26 Jul 2013 12:43:03 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1374835075-14659-1-git-send-email-aik@ozlabs.ru>
In-Reply-To: <1374835075-14659-1-git-send-email-aik@ozlabs.ru>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4] hcd-ohci: add dma error handling
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org

  Hi,

> This also adds ohci_stop() call to ohci_bus_start() to handle possible
> failure of qemu_new_timer_ns().

> * ohci_stop renamed to ohci_die to describe the action better

Except in the commit message ...

Also scripts/checkpatch.pl complains:

ERROR: return is not a function, parentheses are not required
#90: FILE: hw/usb/hcd-ohci.c:590:
+    return (get_dwords(ohci, addr, (uint32_t *)td, 4) ||

ERROR: return is not a function, parentheses are not required
#109: FILE: hw/usb/hcd-ohci.c:622:
+    return (put_dwords(ohci, addr, (uint32_t *)td, 4) ||

We are almost there now ;)

cheers,
  Gerd