From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42574) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2hRr-00009B-3N for qemu-devel@nongnu.org; Fri, 26 Jul 2013 08:48:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V2hRm-0005bk-Ct for qemu-devel@nongnu.org; Fri, 26 Jul 2013 08:48:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:25718) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2hRm-0005aS-1q for qemu-devel@nongnu.org; Fri, 26 Jul 2013 08:48:38 -0400 Message-ID: <51F27021.60905@redhat.com> Date: Fri, 26 Jul 2013 06:48:33 -0600 From: Eric Blake MIME-Version: 1.0 References: <1374842387-17146-1-git-send-email-armbru@redhat.com> <1374842387-17146-2-git-send-email-armbru@redhat.com> In-Reply-To: <1374842387-17146-2-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Grs9nNlohMT9IIRIne4cr2FArEfVHEVQr" Subject: Re: [Qemu-devel] [PATCH 1/9] tests: QAPI schema parser tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: aliguori@us.ibm.com, akong@redhat.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Grs9nNlohMT9IIRIne4cr2FArEfVHEVQr Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/26/2013 06:39 AM, Markus Armbruster wrote: > The parser handles erroneous input badly. To be improved shortly. >=20 > Signed-off-by: Markus Armbruster > --- Lots of proof on how bad it is! I'd also like to see a couple tests on trailing commas: { 'enum': 'Foo', [ 'bar' ], } { 'enum': 'Gur', [ 'ble', ] } since we have had patches in the past to clean them up (shame on JSON for copying C89 instead of C99 with regards to trailing commas). Either way, Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Grs9nNlohMT9IIRIne4cr2FArEfVHEVQr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJR8nAhAAoJEKeha0olJ0Nq9rkH+gOWpBwlHC0rZoAsiqg1EJtO I9SOIf319Caj/B3k+vw7ongS2rGtEPIkX6F9O53xsPpnN36vnZv0JVTovR1gbI6+ LMAjnHmsP7MJt5TbmJbAzRlvG7F/zYetuwxGaUO4n7CyAMraNfrwz1L2pO66IJ4n e9tqtoORJw0gI0bbKoI3zYXXhFYtG8Ukz/HYUpJbEgS8vDTUa4cYENEv96WeYzFW VfapxsAxQXwkX1IwA8sPDvd8zfVqQMKx8ve9V/Imhn5qYTTarP4oRZrCjtbt+eb4 mLjNw53kVq4k8fNxBEtNVZWIJiNL8ohSq5ngnGRCCEELsiUXizL3yYDrEs5kBrE= =AA/B -----END PGP SIGNATURE----- --Grs9nNlohMT9IIRIne4cr2FArEfVHEVQr--