From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47541) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2hjC-000130-FO for qemu-devel@nongnu.org; Fri, 26 Jul 2013 09:06:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V2hjB-0003kB-A4 for qemu-devel@nongnu.org; Fri, 26 Jul 2013 09:06:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:17769) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2hjB-0003k5-27 for qemu-devel@nongnu.org; Fri, 26 Jul 2013 09:06:37 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6QD6a7f023737 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 26 Jul 2013 09:06:36 -0400 Message-ID: <51F2745A.7090308@redhat.com> Date: Fri, 26 Jul 2013 07:06:34 -0600 From: Eric Blake MIME-Version: 1.0 References: <1374584606-5615-1-git-send-email-kwolf@redhat.com> <1374584606-5615-6-git-send-email-kwolf@redhat.com> In-Reply-To: <1374584606-5615-6-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="o1Qb6hPHXx6nJPR0tiDOpniUp9vCBneQ4" Subject: Re: [Qemu-devel] [PATCH 05/18] docs: Document QAPI union types List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: armbru@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --o1Qb6hPHXx6nJPR0tiDOpniUp9vCBneQ4 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/23/2013 07:03 AM, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > docs/qapi-code-gen.txt | 58 ++++++++++++++++++++++++++++++++++++++++++= +++----- > 1 file changed, 53 insertions(+), 5 deletions(-) > +=3D=3D=3D Complex types =3D=3D=3D > =20 > A complex type is a dictionary containing a single key who's value is = a pre-existing, but as long as you are touching this, fix the grammar: s/who's/whose/ > dictionary. This corresponds to a struct in C or an Object in JSON. = An > @@ -47,13 +53,57 @@ The use of '*' as a prefix to the name means the me= mber is optional. Optional > members should always be added to the end of the dictionary to preserv= e > backwards compatibility. > =20 > +=3D=3D=3D Enumeration types =3D=3D=3D > + > An enumeration type is a dictionary containing a single key who's valu= e is a s/who's/whose/ With those fixes, Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --o1Qb6hPHXx6nJPR0tiDOpniUp9vCBneQ4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJR8nRaAAoJEKeha0olJ0NqXRwIAKmf48nLqg5ePjuKFVVXWkzo Xx1WEUJENidnOabBlFOlno9S2vrYF8gcBn2rdi+NZPUzdV1YqFmUNWXRrAp7Su1E dk9JmAql0YqDX1ZWGC1bB78ahaJquHbx2ykVu3BtoNfZLWP1wBYKDcDoboUX6C19 G8/fZoe+9UZHXVN9DM+AyWp4MtTFEeAeSJ40BAQdDtA4ZyGSzfErpvnxLPrJSkEj V3SpWMlkl4nMf1s96zonJv6ziAK7AU+GSFpNWUZ0wEXSw/+e4M1L2hrWEqye7sdf JRjW//+DkrsJgDxMSU01yhdKNvrP850wXNGlBVOns31Mh0djT1oq1lrv7x2wXzc= =m8KK -----END PGP SIGNATURE----- --o1Qb6hPHXx6nJPR0tiDOpniUp9vCBneQ4--