Re: [Qemu-devel] [PATCH v2 0/3] qemu-char: ringbuf fixes

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1570 bytes --]

On 07/26/2013 08:44 AM, Markus Armbruster wrote:
> Fix code to match documentation.  The patches take pains to preserve
> command-line, HMP and QMP bug-compatibility.  I'm not sure that's
> actually needed, because:
> 
> * All: the documented way to use the driver never worked in any
>   released version, and the way that worked was undocumented.
> 
> * QMP: I doubt anyone used chardev-add / chardev-remove in anger,
>   because serious use surely would've run into the bug fixed in commit
>   commit 2ea3e2c "qemu-char: Fix ID reuse after chardev-remove for
>   qapi-based init".
> 
> I include the compatibility gunk anyway, so we can have a more
> informed discussion.

Libvirt 1.1.1 has added patches that try to use chardev-add; but so far,
it only uses 'null', 'pty', 'file', 'parallel', 'serial', and 'socket'
backends.  But if libvirt adds support for a ringbuf device, it would be
nice to support it on as many qemu versions at once as possible, rather
than having to determine whether qemu is new enough to have fixed
semantics vs. using the undocumented backend of the older semantics.  So
I appreciate the attempt at back-compat.

> 
> You might want to apply this after my "Our QAPI parser is a hack,																																																	
> replace it" series, so the indented comment in PATCH 3/3 works by
> design rather than accident.

Heh :)

Series:
Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]