From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50084) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2jbO-0001Qd-NZ for qemu-devel@nongnu.org; Fri, 26 Jul 2013 11:06:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V2jbN-0002wL-AM for qemu-devel@nongnu.org; Fri, 26 Jul 2013 11:06:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27791) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2jbM-0002w7-UH for qemu-devel@nongnu.org; Fri, 26 Jul 2013 11:06:41 -0400 Message-ID: <51F2907D.2030301@redhat.com> Date: Fri, 26 Jul 2013 09:06:37 -0600 From: Eric Blake MIME-Version: 1.0 References: <1374849874-25531-1-git-send-email-armbru@redhat.com> In-Reply-To: <1374849874-25531-1-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="sx21WTWBPudseTOXR7ENJn3BS5F9pjKx3" Subject: Re: [Qemu-devel] [PATCH v2 0/3] qemu-char: ringbuf fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: aliguori@us.ibm.com, lilei@linux.vnet.ibm.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, kraxel@redhat.com, akong@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --sx21WTWBPudseTOXR7ENJn3BS5F9pjKx3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/26/2013 08:44 AM, Markus Armbruster wrote: > Fix code to match documentation. The patches take pains to preserve > command-line, HMP and QMP bug-compatibility. I'm not sure that's > actually needed, because: >=20 > * All: the documented way to use the driver never worked in any > released version, and the way that worked was undocumented. >=20 > * QMP: I doubt anyone used chardev-add / chardev-remove in anger, > because serious use surely would've run into the bug fixed in commit > commit 2ea3e2c "qemu-char: Fix ID reuse after chardev-remove for > qapi-based init". >=20 > I include the compatibility gunk anyway, so we can have a more > informed discussion. Libvirt 1.1.1 has added patches that try to use chardev-add; but so far, it only uses 'null', 'pty', 'file', 'parallel', 'serial', and 'socket' backends. But if libvirt adds support for a ringbuf device, it would be nice to support it on as many qemu versions at once as possible, rather than having to determine whether qemu is new enough to have fixed semantics vs. using the undocumented backend of the older semantics. So I appreciate the attempt at back-compat. >=20 > You might want to apply this after my "Our QAPI parser is a hack, = =09 > replace it" series, so the indented comment in PATCH 3/3 works by > design rather than accident. Heh :) Series: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --sx21WTWBPudseTOXR7ENJn3BS5F9pjKx3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJR8pB9AAoJEKeha0olJ0NqrNgH/j7nPKSdnYLMOP0x6P6XMPuc ECLpQO2Tka0f0ViF+iz8zh7SFAQkp9v5KZsIfdcAE2ofWSvnu7UVmRvV7+Pgc5FL 2yo/9gwE84yJbDpXnAitrog6kPUoyrKvcM9hsyzEKnP+BbQivNbpYD4rbilc6+G0 TMQoruEj+Nl7gbbr+bcaznOPnQslqo485y8YaBdE7yAp9wiak1RUASzk4f93aS4L TjHJqYBz0wJ8qAYWS8CU5AwWb/IStH5NIrCHG+927E3GJBV6YNA0HK8waQXM7M6I FnPCclG3d5TVxXQ1Al/5I0UJ8L43ig96dQRzEYd9braZbkFhekU+IZl1nFPAEg4= =Z/YN -----END PGP SIGNATURE----- --sx21WTWBPudseTOXR7ENJn3BS5F9pjKx3--