From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49651) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2l7k-0003sL-6K for qemu-devel@nongnu.org; Fri, 26 Jul 2013 12:44:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V2l7i-0004jx-TH for qemu-devel@nongnu.org; Fri, 26 Jul 2013 12:44:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27177) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2l7i-0004jq-IE for qemu-devel@nongnu.org; Fri, 26 Jul 2013 12:44:10 -0400 Message-ID: <51F2A755.1080906@redhat.com> Date: Fri, 26 Jul 2013 10:44:05 -0600 From: Eric Blake MIME-Version: 1.0 References: <1374584606-5615-1-git-send-email-kwolf@redhat.com> <1374584606-5615-14-git-send-email-kwolf@redhat.com> <51F29F77.608@redhat.com> <20130726162655.GC18446@dhcp-200-207.str.redhat.com> In-Reply-To: <20130726162655.GC18446@dhcp-200-207.str.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OLGPnOItLnEAog4ll98fcG1K9Ipiu41EK" Subject: Re: [Qemu-devel] [PATCH 13/18] blockdev: Rename I/O throttling options for QMP List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: armbru@redhat.com, =?UTF-8?B?QmVub8OudCBDYW5ldA==?= , qemu-devel@nongnu.org, stefanha@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --OLGPnOItLnEAog4ll98fcG1K9Ipiu41EK Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/26/2013 10:26 AM, Kevin Wolf wrote: >> This patch will probably conflict with Beno=C3=AEt's work on leaky buc= ket >> throttling; can the two of you decide which one should go in first? A= re >> we trying to target both this series and leaky bucket throttling for 1= =2E6? >=20 > If you complete the review before I leave today, I might still send a > pull request, but as I'm going to disable blockdev-add and the new > options once again for 1.6, it doesn't really matter that much. In other words, just as it was in 1.5, the new parser is cool enough to implement the framework now to ease backport efforts, but untested enough that we'd rather defer use of that framework until after we are back out of freeze. >=20 > Beno=C3=AEt's series is for 1.7 as well, if I understood Stefan correct= ly. He Even though the latest subject line requests for-1.6? https://lists.gnu.org/archive/html/qemu-devel/2013-07/msg04005.html > said he was going to merge a bug fix part of it for 1.6 and leave the > rest for 1.7. (I haven't been following the throttling series myself, > that's why I can't comment in much more detail.) I guess I also need to comment on that series - we're late enough that bug fixes are okay, but new options are risky; and the tail end of that series adds new options to throttling as part of switching to a new algorithm. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --OLGPnOItLnEAog4ll98fcG1K9Ipiu41EK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJR8qdVAAoJEKeha0olJ0NqPk8H/0dWUqlVigKxUwa1+0PboFbR dytN4RgRdfhk1tg/jt4mcDOgO6ZQWuD79O9ORtdflFHxXLq9JGjlJ2OfF6+mimf6 92uqzKyKg5svm9/b/QNcVUZzGbNH4CdMqKlnMGfuLFGJI62OA0huHmNEn0bEJV0o 7kJqq2U9TYe7v910TAmUxCKHnksEMX39wzibp2hKLPcEmC3Ej4aJ4k6YO8zrp6fg xDJ0QNHo56hwDWTSIIVFRWfa7WeUbrKIus0yq1Y4/3hocXpaEqG2oCIkpmLvVpsW u+F6pIf0/WTysIsOmTte6knnZkiZ5k2E2f0YQUS12sZ2RsjwGpdP0ENz/m6SYaQ= =UXEM -----END PGP SIGNATURE----- --OLGPnOItLnEAog4ll98fcG1K9Ipiu41EK--