From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60324) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2nMp-0005VS-Qj for qemu-devel@nongnu.org; Fri, 26 Jul 2013 15:07:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V2nMo-0006se-53 for qemu-devel@nongnu.org; Fri, 26 Jul 2013 15:07:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43178) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2nMn-0006sZ-PZ for qemu-devel@nongnu.org; Fri, 26 Jul 2013 15:07:54 -0400 Message-ID: <51F2C902.7050609@redhat.com> Date: Fri, 26 Jul 2013 13:07:46 -0600 From: Eric Blake MIME-Version: 1.0 References: <1374596968-20181-1-git-send-email-benoit@irqsave.net> In-Reply-To: <1374596968-20181-1-git-send-email-benoit@irqsave.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="obmnJit67gTTtsnKGHLDRUmPTM4PnogsQ" Subject: Re: [Qemu-devel] [PATCH V3 for-1.6 0/5] Leaky bucket throttling and features List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --obmnJit67gTTtsnKGHLDRUmPTM4PnogsQ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/23/2013 10:29 AM, Beno=C3=AEt Canet wrote: > The first patch fixes the throttling which was broken by a previous com= mit. >=20 > The next patch replace the existing throttling algorithm by the well de= scribed > leaky bucket algorithm. >=20 > Third patch implement bursting by adding *_threshold parameters to > qmp_block_set_io_throttle. >=20 > The last one allow to define the max size of an io when throttling by i= ops via > iops_sector_count to avoid vm users cheating on the iops limit. >=20 > The last patch adds a metric reflecting how much the I/O are throttled.= >=20 > since v1: > Add throttling percentage metric [Beno=C3=AEt] >=20 > since v2: > Enable timer only during I/O activity [Stefan] > Mark function as coroutine_fn [Stefan] > Guard these function checking they are in a coroutine [Stefan] > Use defines to access buckets [Stefan] > Fix typo [Stefan] > reset throttling metric on iddle [Beno=C3=AEt] > rename invalid to check_io_limit [Stefan] >=20 > Beno=C3=AEt Canet (5): > block: Repair the throttling code. This is probably okay for 1.6 (in fact, now's the RIGHT time to be fixing bugs). > block: Modify the throttling code to implement the leaky bucket > algorithm. but this sounds too risky now that we have passed soft freeze; as mentioned on the thread on blockdev-add, this part is definitely 1.7 material, and the series should be split and subject lines updated to reflect that. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --obmnJit67gTTtsnKGHLDRUmPTM4PnogsQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJR8skCAAoJEKeha0olJ0NqdGwH/iQK6GlaVe5tswmzp0nj1Qi+ SyXKIdi1VFtrP40SLwpgllYaSNvqrD6zSrLSnIfwumq3MocrX1L9eFS6PZ1gJWDb Z+fkA4Uqu+IKq8Ur1s0X9p2jcqv5zL9lh9xtXV88RNi55ZUeXfO5y9C8P8bNtcQq UkGqlLoBgHhIGcT4XRa3vna4W3oAQJSvuE/RD0FrRflDUrvaDNUzxQVjYf+ZDkNZ wXOOiANSw0yNwXZts9GoLn6UHxJkwWx9ZtVkCcV1iark0i0p8VrqoA98zYRlQtMH BT2RbysRg0eVR+nYAuG/lWQZj9erHXrpFZyxOGfgbRosZAOgXWyEXxMB0Up+zZI= =HJ1T -----END PGP SIGNATURE----- --obmnJit67gTTtsnKGHLDRUmPTM4PnogsQ--