From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39625) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2nog-0001b8-RA for qemu-devel@nongnu.org; Fri, 26 Jul 2013 15:36:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V2nof-0000pq-3F for qemu-devel@nongnu.org; Fri, 26 Jul 2013 15:36:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11644) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2noe-0000pS-O9 for qemu-devel@nongnu.org; Fri, 26 Jul 2013 15:36:40 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6QJaesx022393 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 26 Jul 2013 15:36:40 -0400 Message-ID: <51F2CFC7.1000504@redhat.com> Date: Fri, 26 Jul 2013 13:36:39 -0600 From: Eric Blake MIME-Version: 1.0 References: <1374584606-5615-8-git-send-email-kwolf@redhat.com> <1374866187-10793-1-git-send-email-kwolf@redhat.com> In-Reply-To: <1374866187-10793-1-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="8LuXE8mjHPebkrTpM9D1x90BWeN4cr7SB" Subject: Re: [Qemu-devel] [PATCH v2 07/17] qapi: Flat unions with arbitrary discriminator List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: armbru@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --8LuXE8mjHPebkrTpM9D1x90BWeN4cr7SB Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/26/2013 01:16 PM, Kevin Wolf wrote: > Instead of the rather verbose syntax that distinguishes base and > subclass fields... >=20 > { "type": "file", > "read-only": true, > "data": { > "filename": "test" > } } >=20 > ...we can now have both in the same namespace, allowing a more direct > mapping of the command line, and moving fields between the common base > and subclasses without breaking the API: >=20 > { "driver": "file", > "read-only": true, > "filename": "test" } >=20 > Signed-off-by: Kevin Wolf > Reviewed-by: Eric Blake > --- > docs/qapi-code-gen.txt | 22 ++++++++++++ > scripts/qapi-types.py | 11 ++++-- > scripts/qapi-visit.py | 90 +++++++++++++++++++++++++++++++++++++-----= -------- > 3 files changed, 98 insertions(+), 25 deletions(-) >=20 > v2: > - make check failed because some of the nested struct code didn't corre= ctly > put separators between the field names, ending up with foo.barbaz ins= tead > of foo.bar.baz for fields, and foo_barbar instead of foo_bar_baz for > functions. Fixed that. Serves me right for doing just a visual code review instead of 'git am && make check'; but now you know why I only gave Reviewed-by instead of the stronger Acked-by. At any rate, this version looks better; Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --8LuXE8mjHPebkrTpM9D1x90BWeN4cr7SB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJR8s/HAAoJEKeha0olJ0NqQXkH/j5e7gBmnlXPCLeAf8ZGU3MB Sug2gJj8VixjOiuPgsRUOP+x4X0sm7rMrK90TehavJ9sPS4GKtnL+03mEjGbkVBs HPuCD8itwn9CNmCcySqpu7xM4sgSQBZMpLI6UlyXqhRZBXWojwITumZpu6jiLsNY l9eTQpHBkcEWf9G4CgVLseOZ0UvdcvSQTgKF4weuI23q36iUiAbXKmLpc0wRH1sP 4aY5IBHGAInzCVGVzOjmpj6Gu4efotJaCd0J/oARlOHHmr/pgW5HOcu+crNP2YaI 0BmxlLHFwdM0iy/U4PQTfrI6DK9aLsLaatJLTVOyzbYapdntZbqaYZ3kIqLgo8o= =ewZ4 -----END PGP SIGNATURE----- --8LuXE8mjHPebkrTpM9D1x90BWeN4cr7SB--