Re: [Qemu-devel] [PATCH 13/18] blockdev: Rename I/O throttling options for QMP

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1165 bytes --]

On 07/26/2013 01:35 PM, Benoît Canet wrote:
>> This patch will probably conflict with Benoît's work on leaky bucket
>> throttling; can the two of you decide which one should go in first?  Are
>> we trying to target both this series and leaky bucket throttling for 1.6?
> 
> I will to rebase my serie on top of this.

s/serie/series/

[Stupid English, where every rule has an exception.  Here, the exception
is that "series" is the correct spelling of both singular and plural
form.  Don't fret, you're not the first non-native speaker to be tripped
up by this oddity.]

> 
> However if anyone has suggestions for the names of the new options the leaky
> bucket serie add it would probably avoid an extra code review.

As I mentioned on that series, one possibility would be to have:

'*throttling': { 'bps-read': nnn, <up to 6 members, as now> }
'*throttling-threshold': { 'bps-read': nnn, ...}

so that instead of naming 6 new members, you are just naming 1 new
struct that shares the same 6 member names as the first struct.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]