From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44750) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2o5u-00037E-DM for qemu-devel@nongnu.org; Fri, 26 Jul 2013 15:54:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V2o5t-0007DR-DY for qemu-devel@nongnu.org; Fri, 26 Jul 2013 15:54:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10137) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2o5t-0007DM-4d for qemu-devel@nongnu.org; Fri, 26 Jul 2013 15:54:29 -0400 Message-ID: <51F2D3EF.70600@redhat.com> Date: Fri, 26 Jul 2013 13:54:23 -0600 From: Eric Blake MIME-Version: 1.0 References: <1374584606-5615-1-git-send-email-kwolf@redhat.com> <1374584606-5615-14-git-send-email-kwolf@redhat.com> <51F29F77.608@redhat.com> <20130726193529.GA5110@irqsave.net> In-Reply-To: <20130726193529.GA5110@irqsave.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="PN05xsNohiQxqT11NguBvDgktKQw9OoaT" Subject: Re: [Qemu-devel] [PATCH 13/18] blockdev: Rename I/O throttling options for QMP List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= Cc: Kevin Wolf , armbru@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --PN05xsNohiQxqT11NguBvDgktKQw9OoaT Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/26/2013 01:35 PM, Beno=C3=AEt Canet wrote: >> This patch will probably conflict with Beno=C3=AEt's work on leaky buc= ket >> throttling; can the two of you decide which one should go in first? A= re >> we trying to target both this series and leaky bucket throttling for 1= =2E6? >=20 > I will to rebase my serie on top of this. s/serie/series/ [Stupid English, where every rule has an exception. Here, the exception is that "series" is the correct spelling of both singular and plural form. Don't fret, you're not the first non-native speaker to be tripped up by this oddity.] >=20 > However if anyone has suggestions for the names of the new options the = leaky > bucket serie add it would probably avoid an extra code review. As I mentioned on that series, one possibility would be to have: '*throttling': { 'bps-read': nnn, } '*throttling-threshold': { 'bps-read': nnn, ...} so that instead of naming 6 new members, you are just naming 1 new struct that shares the same 6 member names as the first struct. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --PN05xsNohiQxqT11NguBvDgktKQw9OoaT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJR8tPvAAoJEKeha0olJ0NqNOsIAIsHQzvgeTlcVNea0mZ5OA/y S236yHe7H3vWKFNJUkvPf+qS7T+vryKaBz6l4INzZkYkgTFwjYCVB+jET2RTSH/C fv7f1hBqlmpl1XLsseUovGpNy8CNuk5a0UvEWuQ0Gh/Gfme4wh8QEHJG2gx1a6s4 ux4Qwm4KWEHJ3VUCNiUzzAqbOyNl1eLL0jedzsOqnVPXxNtBMyYd0yN0UrD6oLwW D2c1SUxyM7XoAssJLQk3Txhzf4m6+LqDZ1qFg0kmPDiYxIR/RxY1tF7wRc2AugbX ntcarZiRSqvDZQwjGq8n8HxnM93JsC8jmFN0bxymM8xsce/XyVO3OG+1YsL74Kc= =CcTI -----END PGP SIGNATURE----- --PN05xsNohiQxqT11NguBvDgktKQw9OoaT--