From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47708) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2pcv-0002PB-Sc for qemu-devel@nongnu.org; Fri, 26 Jul 2013 17:32:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V2pcs-0003Hp-NT for qemu-devel@nongnu.org; Fri, 26 Jul 2013 17:32:41 -0400 Received: from cantor2.suse.de ([195.135.220.15]:46288 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2pcs-0003HW-Ed for qemu-devel@nongnu.org; Fri, 26 Jul 2013 17:32:38 -0400 Message-ID: <51F2EAED.3040003@suse.de> Date: Fri, 26 Jul 2013 23:32:29 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1373408640-6046-1-git-send-email-afaerber@suse.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH qom-cpu v3 00/41] QOM CPUState, part 11: GDB stub List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Filippov , "Edgar E. Iglesias" Cc: Peter Maydell , Anthony Green , qemu-devel@nongnu.org, Blue Swirl , Michael Walle , Jan Kiszka , Anthony Liguori , Paolo Bonzini , Guan Xuetao , =?UTF-8?B?QXVyw6lsaWVuIEphcm5v?= , Richard Henderson Am 23.07.2013 12:32, schrieb Max Filippov: > On Wed, Jul 10, 2013 at 2:23 AM, Andreas F=C3=A4rber = wrote: >> Hello, >> >> This series cleans up gdbstub by changing all its internal CPU state t= o CPUState >> and by moving most target-specific code into the target directories. >> >> Support for m68k, moxie and unicore32 to set the PC via gdbstub is add= ed. >> >> Lightweight subclasses for XtensaCPU are introduced, keeping the Xtens= aConfig >> mechanisms, to stop xtensa from deviating at gdbstub level wrt registe= r count. >> >> I still wonder whether there would be interest in adding a "program-co= unter" >> dynamic property to the CPU, given that a setter has been factored out= here? >> >> v3 avoids find_cpu() related breakages by deferring GDBState::c_cpu co= nversion >> until GDBState::g_cpu and find_cpu() can easily be converted, too. >> >> Available for testing at: >> git://github.com/afaerber/qemu-cpu.git qom-cpu-11.v3 >> https://github.com/afaerber/qemu-cpu/commits/qom-cpu-11.v3 >=20 > xtensa parts: Acked-by: Max Filippov Thanks, applied to qom-cpu: https://github.com/afaerber/qemu-cpu/commits/qom-cpu Edgar, since I got no feedback on the crisv10 patch but got an ack on the equivalent do_interrupt() change, I'm assuming you're okay with this. We can still do code cleanups unifying pre-v32 stuff as follow-up. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg