From: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Blue Swirl <blauwirbel@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] ioport: qemu-system-sparc64 currently broken
Date: Fri, 26 Jul 2013 23:21:22 +0100 [thread overview]
Message-ID: <51F2F662.9000907@ilande.co.uk> (raw)
Hi Jan/Paolo,
I've just updated my local QEMU repository to git master for OpenBIOS
testing and it seems that the ioport changes break SPARC64. git bisect
points to this commit:
commit b40acf99bef69fa8ab0f9092ff162fde945eec12
Author: Jan Kiszka <jan.kiszka@siemens.com>
Date: Mon Jun 24 10:45:09 2013 +0200
ioport: Switch dispatching to memory core layer
The current ioport dispatcher is a complex beast, mostly due to the
need to deal with old portio interface users. But we can overcome it
without converting all portio users by embedding the required base
address of a MemoryRegionPortio access into that data structure. That
removes the need to have the additional MemoryRegionIORange structure
in the loop on every access.
To handle old portio memory ops, we simply install dispatching handlers
for portio memory regions when registering them with the memory core.
This removes the need for the old_portio field.
We can drop the additional aliasing of ioport regions and also the
special address space listener. cpu_in and cpu_out now simply call
address_space_read/write. And we can concentrate portio handling in a
single source file.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
I suspect that there may be multiple breakages here (as HEAD blows up
differently with a trap failure), but this is definitely the start of
the chain.
Reproducing the bug is easy - simply run qemu-system-sparc64 without any
parameters.
Many thanks,
Mark.
next reply other threads:[~2013-07-26 22:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-26 22:21 Mark Cave-Ayland [this message]
2013-07-27 8:55 ` [Qemu-devel] ioport: qemu-system-sparc64 currently broken Paolo Bonzini
2013-07-27 13:33 ` Mark Cave-Ayland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F2F662.9000907@ilande.co.uk \
--to=mark.cave-ayland@ilande.co.uk \
--cc=blauwirbel@gmail.com \
--cc=jan.kiszka@siemens.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).