From: "Andreas Färber" <afaerber@suse.de>
To: Igor Mammedov <imammedo@redhat.com>
Cc: qemu-devel@nongnu.org, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/6] pc: move IO_APIC_DEFAULT_ADDRESS to include/hw/i386/ioapic.h
Date: Sun, 28 Jul 2013 11:54:46 +0200 [thread overview]
Message-ID: <51F4EA66.6010001@suse.de> (raw)
In-Reply-To: <1374996553-21828-2-git-send-email-imammedo@redhat.com>
Am 28.07.2013 09:29, schrieb Igor Mammedov:
> From: "Michael S. Tsirkin" <mst@redhat.com>
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Missing Reviewed-bys from Gerd and me.
Andreas
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---
> hw/i386/pc.c | 2 --
> include/hw/i386/ioapic.h | 1 +
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> index 2a87563..b0b98a8 100644
> --- a/hw/i386/pc.c
> +++ b/hw/i386/pc.c
> @@ -75,8 +75,6 @@
> #define FW_CFG_E820_TABLE (FW_CFG_ARCH_LOCAL + 3)
> #define FW_CFG_HPET (FW_CFG_ARCH_LOCAL + 4)
>
> -#define IO_APIC_DEFAULT_ADDRESS 0xfec00000
> -
> #define E820_NR_ENTRIES 16
>
> struct e820_entry {
> diff --git a/include/hw/i386/ioapic.h b/include/hw/i386/ioapic.h
> index 86e63da..6245388 100644
> --- a/include/hw/i386/ioapic.h
> +++ b/include/hw/i386/ioapic.h
> @@ -21,6 +21,7 @@
> #define HW_IOAPIC_H
>
> #define IOAPIC_NUM_PINS 24
> +#define IO_APIC_DEFAULT_ADDRESS 0xfec00000
>
> void ioapic_eoi_broadcast(int vector);
>
>
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2013-07-28 9:55 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-28 7:29 [Qemu-devel] [PATCH 0/6 v2 for-1.6] pc: limit 64 bit hole to 2G by default Igor Mammedov
2013-07-28 7:29 ` [Qemu-devel] [PATCH 1/6] pc: move IO_APIC_DEFAULT_ADDRESS to include/hw/i386/ioapic.h Igor Mammedov
2013-07-28 9:54 ` Andreas Färber [this message]
2013-07-28 17:19 ` Igor Mammedov
2013-07-28 17:37 ` Andreas Färber
2013-07-28 7:29 ` [Qemu-devel] [PATCH 2/6] pc: add I440FX QOM cast macro Igor Mammedov
2013-07-28 9:57 ` Andreas Färber
2013-07-28 17:21 ` Igor Mammedov
2013-07-28 17:24 ` Andreas Färber
2013-07-28 18:05 ` Igor Mammedov
2013-07-28 7:29 ` [Qemu-devel] [PATCH 3/6] utils: add range_size() wrapper Igor Mammedov
2013-07-28 7:29 ` [Qemu-devel] [PATCH 4/6] pc: replace i440fx_common_init() with i440fx_init() as it isn't used by anywhere else Igor Mammedov
2013-07-28 10:07 ` Andreas Färber
2013-07-28 7:29 ` [Qemu-devel] [PATCH 5/6] pc: add Q35 to QOM composition tree under /machine Igor Mammedov
2013-07-28 10:08 ` Andreas Färber
2013-07-28 7:29 ` [Qemu-devel] [PATCH 6/6] pc: limit 64 bit hole to 2G by default Igor Mammedov
2013-07-28 7:57 ` Michael S. Tsirkin
2013-07-28 8:21 ` Igor Mammedov
2013-07-28 9:11 ` Michael S. Tsirkin
2013-07-28 10:17 ` Andreas Färber
2013-07-28 17:40 ` Igor Mammedov
2013-07-28 19:48 ` Michael S. Tsirkin
2013-07-30 21:34 ` Michael Roth
2013-07-28 17:33 ` Igor Mammedov
2013-07-28 19:51 ` Michael S. Tsirkin
2013-07-29 7:55 ` Igor Mammedov
2013-07-29 8:16 ` Michael S. Tsirkin
2013-07-28 9:13 ` Michael S. Tsirkin
2013-07-28 17:34 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F4EA66.6010001@suse.de \
--to=afaerber@suse.de \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).